fix: fixing syncDirection for syncObjects in host mode

Assets/Mirage/Runtime/NetworkBehaviour.cs

@@ -268,7 +268,7 @@ protected internal void InitSyncObject(ISyncObject syncObject)
 
         private void SyncObject_OnChange()
         {
-            if (SyncSettings.ShouldSyncFrom(Identity))
+            if (SyncSettings.ShouldSyncFrom(Identity, true))
             {
                 _anySyncObjectDirty = true;
                 Identity.SyncVarSender.AddDirtyObject(Identity);
@@ -284,7 +284,7 @@ private void SyncObject_OnChange()
         /// </summary>
         public void UpdateSyncObjectShouldSync()
         {
-            var shouldSync = SyncSettings.ShouldSyncFrom(Identity);
+            var shouldSync = SyncSettings.ShouldSyncFrom(Identity, true);
 
             if (logger.LogEnabled()) logger.Log($"Settings SyncObject sync on to {shouldSync} for {this}");
             for (var i = 0; i < syncObjects.Count; i++)
@@ -310,7 +310,7 @@ public void SetDirtyBit(ulong bitMask)
 
             _syncVarDirtyBits |= bitMask;
 
-            if (SyncSettings.ShouldSyncFrom(Identity))
+            if (SyncSettings.ShouldSyncFrom(Identity, false))
                 Identity.SyncVarSender.AddDirtyObject(Identity);
         }
 

Assets/Mirage/Runtime/NetworkIdentity.cs

@@ -690,7 +690,7 @@ private void OnSerialize(int i, NetworkBehaviour comp, NetworkWriter writer, boo
                     continue;
 
                 // check if we should be writing this components
-                if (!comp.SyncSettings.ShouldSyncFrom(this))
+                if (!comp.SyncSettings.ShouldSyncFrom(this, false))
                     continue;
 
                 if (logger.LogEnabled()) logger.Log($"OnSerializeAllSafely: '{name}', component '{comp.GetType()}', initial state: '{initialState}'");

Assets/Mirage/Runtime/SyncSettings.cs

@@ -55,7 +55,7 @@ public static void UpdateTime(float interval, SyncTiming timing, ref float nextS
             }
         }
 
-        public bool ShouldSyncFrom(NetworkIdentity identity)
+        public bool ShouldSyncFrom(NetworkIdentity identity, bool syncInHostMode)
         {
             if ((From & SyncFrom.Server) != 0 && identity.IsServer)
             {
@@ -65,8 +65,13 @@ public bool ShouldSyncFrom(NetworkIdentity identity)
 
                 // dont need to check SyncTo.Owner, it is only case left here
 
-                // if to.owner, only sync if not host
-                return !identity.IsClient; // not host
+                // note: need syncInHostMode check for syncobjcets, so that it wont set ReadOnly flag
+                if (syncInHostMode)
+                    return true;
+                else
+                    // dont sync for host
+                    // if to.owner, only sync if not host
+                    return !identity.IsClient; // not host
             }
 
             if ((From & SyncFrom.Owner) != 0 && identity.HasAuthority)
@@ -75,7 +80,11 @@ public bool ShouldSyncFrom(NetworkIdentity identity)
 
                 // if from owner, must be to server
                 if ((To & SyncTo.Server) != 0)
-                { // true if not host OR to ObserversOnly
+                {
+                    if (syncInHostMode)
+                        return true;
+
+                    // true if not host OR to ObserversOnly
                     return !identity.IsServer || (To & SyncTo.ObserversOnly) != 0;
                 }
             }

Assets/Tests/Runtime/Syncing/SyncDirectionObject_Host.cs

@@ -0,0 +1,96 @@
+using System.Collections;
+using NUnit.Framework;
+using UnityEngine.TestTools;
+
+namespace Mirage.Tests.Runtime.Syncing
+{
+    public class SyncDirectionObjectFromServer_Host : SyncDirectionTestBase_Host<MockPlayerWithList>
+    {
+        private const int listValue = 5;
+
+        [UnityTest]
+        public IEnumerator ToOwner()
+        {
+            SetDirection(SyncFrom.Server, SyncTo.Owner);
+
+            hostComponent.guild = guild;
+            hostComponent.MySyncList.Add(listValue);
+
+            // wait for sync
+            yield return null;
+            yield return null;
+
+            Assert.That(hostComponent.guild.name, Is.EqualTo(guild.name));
+            Assert.That(hostComponent.MySyncList.Count, Is.EqualTo(1));
+            Assert.That(hostComponent.MySyncList[0], Is.EqualTo(listValue));
+
+            Assert.That(ObserverComponent.guild.name, Is.Null.Or.Empty);
+            Assert.That(ObserverComponent.MySyncList.Count, Is.Zero);
+        }
+
+        [UnityTest]
+        public IEnumerator ToObserver()
+        {
+            SetDirection(SyncFrom.Server, SyncTo.ObserversOnly);
+
+            hostComponent.guild = guild;
+            hostComponent.MySyncList.Add(listValue);
+
+            // wait for sync
+            yield return null;
+            yield return null;
+
+            // host mode, so should still be set
+            Assert.That(hostComponent.guild.name, Is.EqualTo(guild.name));
+            Assert.That(hostComponent.MySyncList.Count, Is.EqualTo(1));
+            Assert.That(hostComponent.MySyncList[0], Is.EqualTo(listValue));
+
+            Assert.That(ObserverComponent.guild.name, Is.EqualTo(guild.name));
+            Assert.That(ObserverComponent.MySyncList.Count, Is.EqualTo(1));
+            Assert.That(ObserverComponent.MySyncList[0], Is.EqualTo(listValue));
+        }
+
+        [UnityTest]
+        public IEnumerator ToOwnerAndObserver()
+        {
+            SetDirection(SyncFrom.Server, SyncTo.OwnerAndObservers);
+
+            hostComponent.guild = guild;
+            hostComponent.MySyncList.Add(listValue);
+
+            // wait for sync
+            yield return null;
+            yield return null;
+
+            Assert.That(hostComponent.guild.name, Is.EqualTo(guild.name));
+            Assert.That(hostComponent.MySyncList.Count, Is.EqualTo(1));
+            Assert.That(hostComponent.MySyncList[0], Is.EqualTo(listValue));
+
+            Assert.That(ObserverComponent.guild.name, Is.EqualTo(guild.name));
+            Assert.That(ObserverComponent.MySyncList.Count, Is.EqualTo(1));
+            Assert.That(ObserverComponent.MySyncList[0], Is.EqualTo(listValue));
+        }
+
+        [UnityTest]
+        public IEnumerator CanAddInStartServer()
+        {
+            var clone = InstantiateForTest(_characterPrefab);
+            var component = clone.GetComponent<MockPlayerWithList>();
+            clone.OnStartServer.AddListener(() =>
+            {
+                component.MySyncList.Add(listValue);
+            });
+
+            serverObjectManager.Spawn(clone);
+
+            // wait for sync
+            yield return null;
+            yield return null;
+
+            var clientObj = _remoteClients[0].Get(component);
+
+            Assert.That(clientObj.MySyncList.Count, Is.EqualTo(1));
+            Assert.That(clientObj.MySyncList[0], Is.EqualTo(listValue));
+        }
+    }
+}

Assets/Tests/Runtime/Syncing/SyncDirectionSyncVarsTest_Host.cs

@@ -9,7 +9,11 @@
 namespace Mirage.Tests.Runtime.Syncing
 {
     // todo find way to avoid having a full copy of this class
-    public class SyncDirectionTestBase_Host : HostSetup<MockPlayer>
+    public class SyncDirectionTestBase_Host : SyncDirectionTestBase_Host<MockPlayer>
+    {
+
+    }
+    public class SyncDirectionTestBase_Host<T> : HostSetup<T> where T : MockPlayer
     {
         protected static readonly MockPlayer.Guild guild = new MockPlayer.Guild("Fun");
         protected static readonly MockPlayer.Guild guild2 = new MockPlayer.Guild("Other");
@@ -24,11 +28,11 @@ public class SyncDirectionTestBase_Host : HostSetup<MockPlayer>
 
 
         /// <summary>Object on client0 that hostOwns</summary>
-        protected MockPlayer ObserverComponent => _remoteClients[0].Get(hostComponent);
+        protected T ObserverComponent => _remoteClients[0].Get(hostComponent);
 
         /// <summary>Objcet that server controls</summary>
         protected NetworkIdentity HostExtraIdentity { get; private set; }
-        protected MockPlayer HostExtraComponent { get; private set; }
+        protected T HostExtraComponent { get; private set; }
 
         protected void ResetCounters()
         {
@@ -49,7 +53,7 @@ protected override async UniTask LateSetup()
             await AddClient();
 
             HostExtraIdentity = InstantiateForTest(_characterPrefab);
-            HostExtraComponent = HostExtraIdentity.GetComponent<MockPlayer>();
+            HostExtraComponent = HostExtraIdentity.GetComponent<T>();
             serverObjectManager.Spawn(HostExtraIdentity);
 
             await UniTask.Yield();
@@ -65,6 +69,7 @@ protected static void SetDirection(NetworkBehaviour behaviour, SyncFrom from, Sy
             behaviour.SyncSettings.From = from;
             behaviour.SyncSettings.To = to;
             behaviour._nextSyncTime = Time.time;
+            behaviour.UpdateSyncObjectShouldSync();
         }
         protected void SetDirection(SyncFrom from, SyncTo to)
         {