Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: il2cpp linux runtime SIGABRT crash with nanosockets (unity 2021.3.15+ ?) #1116

Merged

Conversation

SoftwareGuy
Copy link
Contributor

This can probably be reverted in a later commit or PR if Unity looks into the StringBuilder SIGABRT crash and fixes their IL2CPP StringBuilder Marshalling. I've reported that bug to Unity, currently awaiting resolution. Confirmed bug with GDB debugger and help of imer and FakeByte.

What this PR features is the following:

  • A fix to prevent IL2CPP SIGABRT crashes when calling NanoSocket's Address.ToString() function. Tested and confirmed working on Manjaro x86_64 with the Mirage Basic demo. It allocates memory however, improved version welcome!
  • Adding our modification notice to the C# wrappers' header.
  • Minor restructure out of pure what-if testing (don't make a new address inside a function iirc).

@SoftwareGuy SoftwareGuy changed the base branch from Linux-Nanosockets-Workaround to master December 8, 2022 13:24
@James-Frowen James-Frowen merged commit ff7148b into MirageNet:master Dec 10, 2022
github-actions bot pushed a commit that referenced this pull request Dec 10, 2022
## [129.1.1](v129.1.0...v129.1.1) (2022-12-10)

### Bug Fixes

* il2cpp linux runtime SIGABRT crash with nanosockets (unity 2021.3.15) ([#1116](#1116)) ([ff7148b](ff7148b))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 129.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants