refactor: use scriptable object for spawnable prefabs #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Frowen
pushed a commit
that referenced
this pull request
Feb 1, 2023
squash of 3 commits: - added network prefabs scriptable object - add tests - renamed Drawers to Inspector
James-Frowen
pushed a commit
that referenced
this pull request
Feb 2, 2023
squash of 3 commits: - added network prefabs scriptable object - add tests - renamed Drawers to Inspector
|
merged as part of #1129 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 2, 2023
# [129.6.0](v129.5.0...v129.6.0) (2023-02-02) ### Bug Fixes * fixing networkprefab drawer height ([8884070](8884070)) ### Features * adding buttons that create gameobject with NetworkIdentity ([0115818](0115818)) * adding custom drawer for networkprefab field ([bb34c04](bb34c04)) * drawing prefab list under NetworkPrefab reference ([8c63726](8c63726)) * hiding COM prefab list when it is empty and NetworkPrefab is set ([5088d33](5088d33)) * making RegisterPrefabs public ([77c8a48](77c8a48)) * use scriptable object for spawnable prefabs ([#1127](#1127)) ([1973e76](1973e76))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaking change changes ClientObjectManager to use a scriptable object instead of a simple list for its spawnable prefabs.
You create the network prefabs object from the ClientObjectManager. A button prompting you to create one appears if the field is null.
I've added a quality-of-life feature that takes your old prefabs, if you're upgrading from an old version, and includes them in the network prefabs scriptable object when you create it through the inspector.
I've also moved the Register All Prefabs button to the network prefabs object from the ClientObjectManager.
The network prefabs object also has an editor, both for IMGUI and one for UI Toolkit to fit in properly with Unity 2022.2.
All the new code should be covered by tests.
This change would also benefit #1122 so it could be added too.