refactor(NetworkManagerGUI): overhaul the debug controls #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were a little lengthy.
Draws the initial window state (Start Server, Client, etc)
because Mirage.Components namespace can't access the Sockets namespace
github-actions bot
pushed a commit
that referenced
this pull request
Jun 16, 2023
# [141.1.0](v141.0.2...v141.1.0) (2023-06-16) ### Features * **NetworkManagerGUI:** overhaul the debug controls ([#1149](#1149)) ([8b97f36](8b97f36))
|
🎉 This PR is included in version 141.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current NetworkManagerGUI that is used by Mirage is rather outdated. Buttons are hard to click on if you have a touch screen, the white text blends in with the scene, etc. Overall, it was begging for an update.
This PR introduces an almost-completely refactored NetworkManagerGUI that is using the
GUI.Windowfunctionality to give it a nice background and title. In the future, one could turn it into a draggable GUI Window, but for now it's more elegant but keeping things simple.Empty space will be used in later updates (current connection count, etc).
Screenshots
