feat: make networkscenemanager optional again #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you need if not null checks in OnDestroy as well |
|
Kudos, SonarCloud Quality Gate passed! |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2021
# [66.2.0](v66.1.0...v66.2.0) (2021-02-17) ### Features * make networkscenemanager optional again ([#595](#595)) ([ed180ff](ed180ff))
|
🎉 This PR is included in version 66.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #586
I used the Tanks example and just deleted the NetworkSceneManager component and hit play. After these changes everything works as normal.