Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stopping the server in host mode doesn't invoke Client.Disconnected on host client #837

Closed
phodoval opened this issue Jun 4, 2021 · 1 comment · Fixed by #838
Closed

Stopping the server in host mode doesn't invoke Client.Disconnected on host client #837

phodoval opened this issue Jun 4, 2021 · 1 comment · Fixed by #838
Labels
released

Comments

@phodoval
Copy link
Contributor

phodoval commented Jun 4, 2021 •
edited

Describe the bug
Calling Server.Stop() in host mode does not lead to Client.Disconnected event being called for the local client, which is a regression.

To Reproduce

  1. Call Server.Stop() in host mode.
  2. Observe Client.Disconnected not being tiriggered.
@phodoval phodoval changed the title Stopping the server in host mode doesn't invoke Client.Disconnected Stopping the server in host mode doesn't invoke Client.Disconnected on host client Jun 4, 2021
James-Frowen added a commit that referenced this issue Jun 4, 2021
@James-Frowen
fix: adding action to pipe connection so client events can be called …
fc43a91 
…on stop

fixes: #837
@James-Frowen James-Frowen mentioned this issue Jun 4, 2021
Merged
James-Frowen added a commit that referenced this issue Jun 4, 2021
@James-Frowen
fix: adding action to pipe connection so client events can be called …
eebe63a 
…on stop (#838)

fix: #837
github-actions bot pushed a commit that referenced this issue Jun 4, 2021
@semantic-release-bot
chore(release): 96.3.0 [skip ci]
ea28f7d 
# [96.3.0](v96.2.1...v96.3.0) (2021-06-04)

### Bug Fixes

* adding action to pipe connection so client events can be called on stop ([#838](#838)) ([eebe63a](eebe63a)), closes [#837](#837)

### Features

* adding host mode stopped as reason for client disconnect ([0054dd5](0054dd5))
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2021

🎉 This issue has been resolved in version 96.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adding action to pipe connection so client events can be called on stop MirageNet/Mirage
1 participant
@phodoval