Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding action to pipe connection so client events can be called on stop #838

Merged
merged 1 commit into from
Jun 4, 2021
Merged

fix: adding action to pipe connection so client events can be called on stop #838

merged 1 commit into from
Jun 4, 2021

Conversation

James-Frowen
Copy link
Member

fix: #837

@sonarcloud
Copy link

sonarcloud bot commented Jun 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@James-Frowen James-Frowen merged commit eebe63a into master Jun 4, 2021
@James-Frowen James-Frowen deleted the pipe-fix branch June 4, 2021 15:18
github-actions bot pushed a commit that referenced this pull request Jun 4, 2021
@semantic-release-bot
chore(release): 96.3.0 [skip ci]
ea28f7d 
# [96.3.0](v96.2.1...v96.3.0) (2021-06-04)

### Bug Fixes

* adding action to pipe connection so client events can be called on stop ([#838](#838)) ([eebe63a](eebe63a)), closes [#837](#837)

### Features

* adding host mode stopped as reason for client disconnect ([0054dd5](0054dd5))
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2021

🎉 This PR is included in version 96.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stopping the server in host mode doesn't invoke Client.Disconnected on host client
1 participant
@James-Frowen