Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be able to remove character from player without destroying it #883

Closed
James-Frowen opened this issue Aug 17, 2021 · 1 comment · Fixed by #978
Closed

Be able to remove character from player without destroying it #883

James-Frowen opened this issue Aug 17, 2021 · 1 comment · Fixed by #978
Labels
enhancement New feature or request released

Comments

@James-Frowen
Copy link
Member

Please explain the suggested feature in detail.

Be able to remove the character object from a networkplayer without destroying or unspawning the gameobject.

This is useful if you want to keep a character in the scene after a player disconnects, but current there is no way to remove ownership from it without unspawning it or replacing it with a new networkidentity

How exactly does this keep you from releasing your game right now?
current workaround, use a dummy networkidentity and use ReplaceCharacter

Can you suggest a possible solution?
improve the RemovePlayerForConnection method
@James-Frowen James-Frowen added the enhancement New feature or request label Aug 17, 2021
James-Frowen added a commit that referenced this issue Nov 1, 2021
@James-Frowen
fix: adding method to remove character without destroying the object
9af4cef 
fixes: #883

BREAKING CHANGE: RemovePlayerForConnection removed, use RemoveCharacter or DestroyCharacter instead
@James-Frowen James-Frowen mentioned this issue Nov 1, 2021
Merged
James-Frowen added a commit that referenced this issue Nov 1, 2021
@James-Frowen
fix: adding method to remove character without destroying the object
9329e2f 
fixes: #883

BREAKING CHANGE: RemovePlayerForConnection removed, use RemoveCharacter or DestroyCharacter instead. Note for RemoveCharacter destroyServerObject now defaults to true
James-Frowen added a commit that referenced this issue Nov 1, 2021
@James-Frowen
fix: adding method to remove character without destroying the object
616eab1 
fixes: #883

BREAKING CHANGE: RemovePlayerForConnection removed, use RemoveCharacter or DestroyCharacter instead. Note for RemoveCharacter destroyServerObject now defaults to true
James-Frowen added a commit that referenced this issue Nov 1, 2021
@James-Frowen
fix: adding method to remove character without destroying the object
19cad00 
fixes: #883

BREAKING CHANGE: RemovePlayerForConnection removed, use RemoveCharacter or DestroyCharacter instead. Note for RemoveCharacter destroyServerObject now defaults to true
github-actions bot pushed a commit that referenced this issue Nov 1, 2021
@semantic-release-bot
chore(release): 110.0.0 [skip ci]
2c071be 
# [110.0.0](v109.0.3...v110.0.0) (2021-11-01)

### Bug Fixes

* adding method to remove character without destroying the object ([19cad00](19cad00)), closes [#883](#883)
* fixing remove authority for host ([528f66b](528f66b))

### BREAKING CHANGES

* RemovePlayerForConnection removed, use RemoveCharacter or DestroyCharacter instead. Note for RemoveCharacter destroyServerObject now defaults to true
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2021

🎉 This issue has been resolved in version 110.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(DONT SQUASH) fix: adding method to remove character without destroying the object MirageNet/Mirage
1 participant
@James-Frowen