Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call syncvar hooks after reading all values for initialState #913

Closed
James-Frowen opened this issue Sep 3, 2021 · 2 comments · Fixed by #915
Closed

Call syncvar hooks after reading all values for initialState #913

James-Frowen opened this issue Sep 3, 2021 · 2 comments · Fixed by #915
Labels
enhancement New feature or request released

Comments

@James-Frowen
Copy link
Member

Please explain the suggested feature in detail.

At the moment order is:

value1 will be set
value1 hook will be called
value2 will be set
value2 hook will be called

for initial state (when objects spawns) it seems like it would make more sense if all the hooks are called after all values are set

value1 will be set
value2 will be set
value1 hook will be called
value2 hook will be called
@James-Frowen James-Frowen added the enhancement New feature or request label Sep 3, 2021
@vladqwerty435
Copy link

Maybe not only for initial state. For every state

James-Frowen added a commit that referenced this issue Sep 4, 2021
@James-Frowen
refactor: setting all syncvars before calling hooks for initial spawn
b678da7 
resolves: #913
@James-Frowen James-Frowen mentioned this issue Sep 4, 2021
Merged
James-Frowen added a commit that referenced this issue Sep 22, 2021
@James-Frowen
refactor: setting all syncvars before calling hooks for initial spawn
00b7e3a 
resolves: #913
James-Frowen added a commit that referenced this issue Sep 23, 2021
@James-Frowen
refactor: setting all syncvars before calling hooks for initial spawn (…
7d4cd20 
…#915)

* refactor: setting all syncvars before calling hooks for initial spawn

resolves: #913

* implementing code
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 105.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: setting all syncvars before calling hooks for initial spawn MirageNet/Mirage
2 participants
@James-Frowen @vladqwerty435