Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: weaver error on guard attributes put on awake #986

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

Hertzole
Copy link
Contributor

@Hertzole Hertzole commented Nov 6, 2021

This PR makes the weaver give an error when Server, Client, HasAuthority, and LocalPlayer are put on Awake.

It also includes tests that check for errors when an attribute has been placed on Awake and also that it doesn't error when you have an Awake method with parameters.

Fixes #984

@James-Frowen James-Frowen merged commit 94f8ac7 into MirageNet:master Nov 6, 2021
James-Frowen added a commit that referenced this pull request Nov 6, 2021
github-actions bot pushed a commit that referenced this pull request Nov 6, 2021
## [111.1.1](v111.1.0...v111.1.1) (2021-11-06)

### Bug Fixes

* weaver error on guard attributes put on awake ([#986](#986)) ([2f89372](2f89372))
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2021

🎉 This PR is included in version 111.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add weaver warning when using [Server] [Client] on Awake
2 participants