Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(transports): removing sendAsync from transports #673

Merged
merged 14 commits into from
Mar 8, 2021
Merged

refactor(transports): removing sendAsync from transports #673

merged 14 commits into from
Mar 8, 2021

Commits on Mar 7, 2021

  1. refactor: splitting IMessageHandler into multiple interfaces

    @James-Frowen
    James-Frowen committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    e43d9cd View commit details
    Browse the repository at this point in the history

  2. adding comments

    @James-Frowen
    James-Frowen committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    972dcea View commit details
    Browse the repository at this point in the history

  3. fixing typo

    @James-Frowen
    James-Frowen committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    d0fc7a5 View commit details
    Browse the repository at this point in the history

  4. updating weaver to use new interfaces

    @James-Frowen
    James-Frowen committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    1744514 View commit details
    Browse the repository at this point in the history

  5. refactor: making NetworkClient implement IMessageSender

    @James-Frowen
    James-Frowen committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    1894215 View commit details
    Browse the repository at this point in the history

  6. removing calls to INetworkClient because they are now in IMessageSender

    @James-Frowen
    James-Frowen committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    656c30f View commit details
    Browse the repository at this point in the history

  7. refactor: removing sendasync 

    - all uses of send use forget
- no use case for wait to see if message was sent
    @James-Frowen
    James-Frowen committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    da11dcf View commit details
    Browse the repository at this point in the history

  8. removing deleted methods from weaver

    @James-Frowen
    James-Frowen committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    174cc1b View commit details
    Browse the repository at this point in the history

  9. refactor: removing sendAsync from transports 

    - all uses of send use forget
- no use case for wait to see if message was sent
    @James-Frowen
    James-Frowen committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    278135c View commit details
    Browse the repository at this point in the history

  10. removing await from send in KcpServerConnection 

    Send will still throw if it fails
    @James-Frowen
    James-Frowen committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    7406c18 View commit details
    Browse the repository at this point in the history

  11. removing use of sendasync

    @James-Frowen
    James-Frowen committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    d4cb3e5 View commit details
    Browse the repository at this point in the history

  12. removing sendAsync from tests

    @James-Frowen
    James-Frowen committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    b90d601 View commit details
    Browse the repository at this point in the history

  13. fixing test

    @James-Frowen
    James-Frowen committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    c24db21 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. Merge branch 'master' into removing-sendAsync-from-transports

    @paulpach
    paulpach committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    01856e3 View commit details
    Browse the repository at this point in the history