Use nanoseconds in ImageFsInfo Timestamp on Linux #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Broken since kubernetes/kubernetes@0d907e0 (k8s v1.16) |
|
ping @nwneisen @neersighted |
neersighted
approved these changes
Aug 23, 2023
According to CRI-API this should be nanoseconds: https://github.com/kubernetes/cri-api/blob/release-1.28/pkg/apis/runtime/v1/api.proto#L1554 Additionally, image_window.go has nanoseconds already.
surik
force-pushed
the
fix-timestame-fsinfo-image-linux
branch
from
c25a051
to
d58653e
Compare
|
This one rebased just in case |
neersighted
approved these changes
Sep 9, 2023
|
The tests look good now. Wonder if there is something else that I have to do to get this merged. |
|
Hey @surik, tests will pass because they are currently pinned to an old version. I've got the fix out so we are running the latest tests versions but we are still working on getting the merged so that everyone is running them. This change looks small enough that I will merge it in. Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to CRI-API this should be nanoseconds:
https://github.com/kubernetes/cri-api/blob/release-1.28/pkg/apis/runtime/v1/api.proto#L1554
Additionally, image_window.go has nanoseconds already.