Migrate seccomp profile #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 18, 2023
|
ping @afbjorklund @neersighted |
Merged
neersighted
requested changes
Sep 5, 2023
neersighted
reviewed
Sep 5, 2023
neersighted
approved these changes
Sep 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method for retrieving the secomp profile path was deprecated in favor of a structure for managing a security profile. This change migrates the code to use the structure rather than the method to get the profile path and do string parsing to determine what profile type is being used. This is now handled using the structure and its methods.
This fixes integration tests related to #198 and moves the pinned integration cri-tools SHA to include tests for these changes.