Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: github.com/docker/docker v24.0.7+incompatible #279

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

AkihiroSuda
Copy link
Contributor

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@nwneisen
Copy link
Collaborator

@AkihiroSuda Thanks for taking a look at this! I'm working on updating some other modules and this was on my checklist.

I see no initial issues with the changes. I'll run some additional tests and then we can get this merged in.

@nwneisen nwneisen self-requested a review November 30, 2023 15:37
@nwneisen
Copy link
Collaborator

I checked the integration tests with the cri log format changes that aren't merged

nneisen@pop-os:~/code/cri-dockerd (go-mod-docker-24): make integration
sudo critest -runtime-endpoint=unix:///var/run/cri-dockerd.sock -ginkgo.skip="runtime should support apparmor|runtime should support reopening container log|runtime should support execSync with timeout|runtime should support selinux|.*should support propagation.*"
[sudo] password for nneisen: 
critest version: d7c0562b
Running Suite: CRI validation - /home/nneisen/code/cri-dockerd
==============================================================
Random Seed: 1701373549

Will run 74 of 86 specs
SSSSSS••••••••••••E1130 12:46:01.921371  112049 remote_runtime.go:319] "CreateContainer in sandbox from runtime service failed" err="rpc error: code = Unknown desc = failed to update container create config: failed to apply container security context for container \"container-with-RunAsGroup-without-RunAsUser-test-b1426edf-75b2-4ca7-ba37-736ce18e39d0\": runAsGroup is specified without a runAsUser" podSandboxID="d5087c5fffba0dc458448bc18f1efa448ef3614380245c4e7398d7b9f5b9252e"
•••••••••••••••••••••••••••••••••Forwarding from 127.0.0.1:12001 -> 80
Forwarding from [::1]:12001 -> 80
Handling connection for 12001
•••Forwarding from 127.0.0.1:12002 -> 12003
Forwarding from [::1]:12002 -> 12003
Handling connection for 12002
•S•••••••S•••••••S••••••••••S•SS

Ran 74 of 86 Specs in 83.068 seconds
SUCCESS! -- 74 Passed | 0 Failed | 0 Pending | 12 Skipped
PASS

No issues reported. This looks good to merge in. Thanks @AkihiroSuda!

@nwneisen nwneisen merged commit 9c5ee55 into Mirantis:master Nov 30, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants