Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image info to the verbose status command #47

Merged
merged 1 commit into from May 24, 2022

Conversation

afbjorklund
Copy link
Contributor

@afbjorklund afbjorklund commented Apr 22, 2022

Do a combination of the cri-o format (with "labels") and the
containerd format (without "chainID") for the info JSON field.

cri-o
https://github.com/cri-o/cri-o/blob/main/server/image_status.go

        struct {
                Labels    map[string]string `json:"labels,omitempty"`
                ImageSpec *specs.Image      `json:"imageSpec"`
        }

containerd (cri plugin)
https://github.com/containerd/containerd/blob/main/pkg/cri/server/image_status.go

struct {
        ChainID   string          `json:"chainID"`
        ImageSpec imagespec.Image `json:"imageSpec"`
}

The info is supposed to include the history, so make a special
call for that in verbose and reverse order to match containerd.

Do a combination of the cri-o format (with "labels") and the
containerd format (without "chainID") for the info JSON field.

The info is supposed to include the history, so make a special
call for that in verbose and reverse order to match containerd.
@evol262 evol262 merged commit 95d74e0 into Mirantis:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants