Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64
When I was running
crictl stats
I wasn't getting any memory usage reported, everything was 0.I checked the response of:
cri-dockerd/libdocker/kube_docker_client.go
Line 612 in 5d7c9ba
And it was:
There is no
PrivateWorkingSet
field being returned from Docker, changing it toUsage
resulted in the following:If you look at the source code of Docker you can see that Windows uses
PrivateWorkingSet
but Unix usesUsage
.Windows:
https://github.com/moby/moby/blob/548614694305d10e25665b4a7d0f61b025d47dd1/daemon/daemon_windows.go#L522
Unix:
https://github.com/moby/moby/blob/548614694305d10e25665b4a7d0f61b025d47dd1/daemon/daemon_unix.go#L1475