-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed docker publish #228
Fixed docker publish #228
Conversation
- Add copyright notices - Currently, CI pushing images only with latest tag: https://travis-ci.org/Mirantis/k8s-AppController/jobs/203410745#L1998-L2001 No one paid attention to this, because the "after_success" step failure doesn't fail build: travis-ci/travis-ci#758 And at the moment a good fix is to use this as the last entry of "script" step instead of "after_success" step.
Review status: 0 of 3 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Really good. Reviewed 3 of 3 files at r1. scripts/docker_publish.sh, line 40 at r1 (raw file):
Lack of consistency in indenting. scripts/docker_publish.sh, line 46 at r1 (raw file):
In all other tests for such case is used scripts/docker_publish.sh, line 49 at r1 (raw file):
Same again. Lack of consistency in indenting. scripts/import.sh, line 38 at r1 (raw file):
👍 Comments from Reviewable |
- Fixed syntax
Review status: 2 of 3 files reviewed at latest revision, 4 unresolved discussions. scripts/docker_publish.sh, line 40 at r1 (raw file): Previously, jellonek (Piotr Skamruk) wrote…
Done. scripts/docker_publish.sh, line 46 at r1 (raw file): Previously, jellonek (Piotr Skamruk) wrote…
Done. scripts/docker_publish.sh, line 49 at r1 (raw file): Previously, jellonek (Piotr Skamruk) wrote…
Done. Comments from Reviewable |
Reviewed 1 of 1 files at r2. Comments from Reviewable |
but @dshulyak pls take a look. Reviewed 2 of 3 files at r1, 1 of 1 files at r2. Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful. scripts/import.sh, line 38 at r1 (raw file): Previously, jellonek (Piotr Skamruk) wrote…
thx. Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful. Comments from Reviewable |
Add copyright notices
Currently, CI pushing images only with latest tag:
https://travis-ci.org/Mirantis/k8s-AppController/jobs/203410745#L1998-L2001
No one paid attention to this, because the "after_success" step failure
doesn't fail build:
after_success failure doesn't fail build travis-ci/travis-ci#758
And at the moment a good fix is to use this as the last entry of
"script" step instead of "after_success" step.
This change is