Status checks if resource was upgraded

[nebril]

All resources now have a Definition to which they need to conform in
order to make an actual status check

---

This change is 

[istalker2]

The commit mostly looks good. The problem is that it adds new status and functionality which is not used by deployment engine (scheduler). Thus it is not clear, how it is going to be used. At least it should be reflected in commit message. Without understanding the purpose it is hard to review the code. My guess is that from now on definitions are going to be the single point of truth and if, for example, I want to set resource label I need to modify definition and rerun the graph rather than doing it through kubectl, as usual

---

Review status: 0 of 30 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

pkg/interfaces/interfaces.go, line 43 at r1 (raw file):

	Delete() error
	Meta(string) interface{}
	EqualToDefinition(interface{}) bool

Shouldn't it be EqualsToDefinition?
Also, correct me if I'm wrong, but resources only use this method in their Status() implementation. If so, why is it part of the resource interface?

---

pkg/resources/configmap.go, line 102 at r1 (raw file):

	if !c.EqualToDefinition(cm) {
		return interfaces.ResourceWaitingForUpgrade, fmt.Errorf(string(interfaces.ResourceWaitingForUpgrade))

Here and in other resources: why it it error? Usually it is either result and nil error, or nil and non-nil error. If there is a special status for this then resource being in that status is not an error condition. Error is when you cannot get the status, for example

---

Comments from Reviewable

[nebril]

Seems like some of the scheduling code got lost during rebase (it was long and painful). Will fix. Thanks for the feedback, will try to fix.

[nebril]

Review status: 0 of 28 files reviewed at latest revision, 2 unresolved discussions.

---

pkg/interfaces/interfaces.go, line 43 at r1 (raw file):

Previously, istalker2 (Stan Lagun) wrote…

Shouldn't it be EqualsToDefinition?
Also, correct me if I'm wrong, but resources only use this method in their Status() implementation. If so, why is it part of the resource interface?

Done.

---

pkg/resources/configmap.go, line 102 at r1 (raw file):

Previously, istalker2 (Stan Lagun) wrote…

Here and in other resources: why it it error? Usually it is either result and nil error, or nil and non-nil error. If there is a special status for this then resource being in that status is not an error condition. Error is when you cannot get the status, for example

Done.

---

Comments from Reviewable