Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix /discovery-methods endpoint #33

Merged
merged 1 commit into from Sep 12, 2016
Merged

Fix /discovery-methods endpoint #33

merged 1 commit into from Sep 12, 2016

Commits on Sep 12, 2016

  1. Fix /discovery-methods endpoint 

    Currently there're two issues with that endpoint:

* It uses DBAPI.get_discovery_methods() without arguments but it
  does receive one.

* It expects DBAPI.get_discovery_methods() to return a list of
  supported discovery methods, but it returns a dictionary instead.

The fix for the first one is to get rid of unused argument, and for the
second one - return a list instead of dictionary. The funny thing is, we
have a correct mock in tests.. it's a production code that's  broken.
    Igor Kalnitsky committed Sep 12, 2016
    Copy the full SHA
    6315fb8 View commit details
    Browse the repository at this point in the history