add test on missing db_key exception

Mirantis · Sep 27, 2017 · 0b07655 · 0b07655
1 parent 7ec2cb1
commit 0b07655
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/kqueen/models.py b/kqueen/models.py
@@ -93,7 +93,7 @@ def get_field_names(self):
         return fields
 
     def get_db_key(self):
-        if not self.id:
+        if self.id and self.id.empty():
             raise Exception('Missing object id')
 
         return '{}{}'.format(self.__class__.get_db_prefix(), self.id.serialize())

diff --git a/kqueen/test_models.py b/kqueen/test_models.py
@@ -65,6 +65,12 @@ def test_exists(self, cluster):
         cluster.save()
         assert Cluster.exists(cluster.id)
 
+    def test_get_db_key_missing(self, cluster):
+        cluster.id.set_value(None)
+
+        with pytest.raises(Exception, match=r'Missing object id'):
+            cluster.get_db_key()
+
 
 class TestFieldCompare:
     def setup(self):