test cyclomatic complexity #230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naumvd95
reviewed
Feb 27, 2018
| @@ -19,7 +19,7 @@ jobs: | |||
| - pip install -e ".[test]" | |||
| - pip check | |||
| script: | |||
| - python3 -m flake8 | |||
| - python3 -m flake8 --max-complexity 10 | |||
There was a problem hiding this comment.
we can increase amount if necessary ) just for notice
This practice was adopted by the NIST Structured Testing methodology, with an observation that since McCabe's original publication, the figure of 10 had received substantial corroborating evidence, but that in some circumstances it may be appropriate to relax the restriction and permit modules with a complexity as high as 15.
There was a problem hiding this comment.
Most of the code can by easily refactored ... except Cluster.topology_data which is a nightmare and have 22.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
mccabeto check cyclomatic complexity.