Validate OS-kubespray cluster before provision #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katyafervent
force-pushed
the
validate-before-provision
branch
from
b7669e5
to
44751a7
Compare
added 2 commits
July 6, 2018 10:52
If there is an error in user-input data, return 400 instead of 500. Validation is made for: * valid image * valid flavor * valid avaliability zone * valid ip for dns * valid master node value * valid network
And not initial string
katyafervent
force-pushed
the
validate-before-provision
branch
from
44751a7
to
bc57769
Compare
ekhomyakova
reviewed
Jul 6, 2018
| self.meta["master_count"] = mc | ||
| self.meta["slave_count"] = self.cluster.metadata["slave_count"] | ||
|
|
||
| self.meta["dns"] = [validate_ip(ip) for ip in |
There was a problem hiding this comment.
I suggest to place it after all is None checks.
There was a problem hiding this comment.
why? I placed it here since it performs faster then checks below, so if error will be here, response will be sent faster
There was a problem hiding this comment.
since it doesn't send api call to the openstack
naumvd95
reviewed
Jul 6, 2018
| resources = { | ||
| "masters": [], | ||
| "slaves": [], | ||
| } | ||
| network = self.c.create_network(self.stack_name) | ||
| subnet = self.c.create_subnet(network, cidr="10.1.0.0/16", | ||
| subnet_name=self.stack_name, | ||
| dns_nameservers=dns) | ||
| dns_nameservers=self.meta['dns']) |
There was a problem hiding this comment.
Some fields are required and some are not, let me also send 400 if required field is not provided
| router = self.c.create_router(name=self.stack_name, | ||
| ext_gateway_net_id=ext_net.id) | ||
| ext_gateway_net_id=self.meta['ext_net'].id) |
| flavor=flavor, | ||
| servers_range=range(self.meta["slave_count"]), | ||
| image=self.meta['image'], | ||
| flavor=self.meta['flavor'], |
ekhomyakova
approved these changes
Jul 6, 2018
naumvd95
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.