Use separate flavors for slave and master nodes #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naumvd95
reviewed
Jul 13, 2018
| "type": "text", | ||
| "order": 30, | ||
| "label": "Flavor", | ||
| "label": "Master flavor", | ||
| "default": config.get("KS_MASTER_FLAVOR"), |
There was a problem hiding this comment.
imo its better to set defaults directly here, for ex m1.medium for master, m1.large for slaves
There was a problem hiding this comment.
decided not to use values from config at all. may be later use profile for each provisioner with predefined settings
| raise ValueError("Flavor for master '%s' is not found" % self.cluster.metadata["master_flavor"]) | ||
| self.meta["slave_flavor"] = self.c.get_flavor(self.cluster.metadata["slave_flavor"]) | ||
| if self.meta["slave_flavor"] is None: | ||
| raise ValueError("Flavor for slave '%s' is not found" % self.cluster.metadata["master_flavor"]) |
There was a problem hiding this comment.
in what case it can be None? through api calls?
There was a problem hiding this comment.
yes, it is api server) we need to validate data on server side too
| self.meta["flavor"] = self.c.get_flavor(self.cluster.metadata["flavor"]) | ||
| if self.meta["flavor"] is None: | ||
| raise ValueError("Flavor '%s' is not found" % self.cluster.metadata["flavor"]) | ||
| self.meta["master_flavor"] = self.c.get_flavor(self.cluster.metadata["master_flavor"]) |
There was a problem hiding this comment.
btw, why some checks are not in try-catch block?
There was a problem hiding this comment.
they are optional
katyafervent
force-pushed
the
separate-flavors-for-masters-and-slaves
branch
from
cc6851d
to
dcdd984
Compare
katyafervent
force-pushed
the
separate-flavors-for-masters-and-slaves
branch
from
dcdd984
to
0e9390a
Compare
ekhomyakova
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.