Get rid of pycrypto #347
Closed
Get rid of pycrypto #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katyafervent
force-pushed
the
get-rid-of-pycrypto
branch
2 times, most recently
from
dd8f00d
to
5becf27
Compare
* Use cryptography package instaed * Update piplock.file to be sync with new dependencies
katyafervent
force-pushed
the
get-rid-of-pycrypto
branch
2 times, most recently
from
f35c4f0
to
c8d3dcd
Compare
naumvd95
suggested changes
Jul 23, 2018
redixin
reviewed
Jul 23, 2018
|
|
||
| def _unpad(self, s): | ||
| return s[:-ord(s[len(s) - 1:])] | ||
| key = hashlib.md5(key.encode('utf-8')).hexdigest() |
There was a problem hiding this comment.
Why changed sha256 to md5?
| @@ -110,11 +109,11 @@ def validate(self): | |||
| """ | |||
| return True | |||
|
|
|||
| def _get_encryption_key(self): | |||
| """Read encryption key and format it. | |||
| def _get_fernet_obj(self): | |||
There was a problem hiding this comment.
You may use AES instead of Fernet to be compatible with old database.
https://cryptography.io/en/latest/hazmat/primitives/symmetric-encryption/
There was a problem hiding this comment.
thanks, I'll take a look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.