Define floating ip's into k8s-config ssl context #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Set all fips in this var to get rid of kubectl ssl-certs issue | ||
| ssl_fips = [] | ||
| for master in metadata["resources"]["masters"]: | ||
| master_fip = master.get("fip", None) |
There was a problem hiding this comment.
we set 'fip' to master anyway, so it an be none) and this line is redundant
https://github.com/Mirantis/kqueen/blob/master/kqueen/engines/openstack_kubespray.py#L723
naumvd95
force-pushed
the
fip-ssl
branch
2 times, most recently
from
dde5d21
to
da8c0f2
Compare
katyafervent
approved these changes
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid kubernetes-sigs/kubespray#1430