Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsync + raw_ssh by default, with gevent backend for celery #397

Merged
merged 15 commits into from Dec 11, 2015

Conversation

dshulyak
Copy link
Contributor

@dshulyak dshulyak commented Dec 1, 2015

No description provided.

@dshulyak dshulyak force-pushed the multi_transports branch 2 times, most recently from 0b48652 to 511d90c Compare December 2, 2015 15:18
@dshulyak dshulyak changed the title [WIP] rsync + raw_ssh by default rsync + raw_ssh by default, with gevent backend for celery Dec 2, 2015
@dshulyak dshulyak force-pushed the multi_transports branch 2 times, most recently from ea6d2e0 to b67fee9 Compare December 3, 2015 05:58
@dshulyak
Copy link
Contributor Author

dshulyak commented Dec 8, 2015

pushed image with tag - solarproject/solar-celery:gevent

def is_connection(arg):
if isinstance(arg, basestring) and '::' in arg:
return True
return False


def parse_dicts_as_collection(child_input, arg):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have now parse_dict_input and parse_dicts_as_collection. Can you merge them?


hosts1 = vr.create('hosts_file1', 'resources/hosts_file', {})[0]
hosts2 = vr.create('hosts_file2', 'resources/hosts_file', {})[0]
node1.connect(hosts1, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why it's removed ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done in templates/nodes.yaml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is just too much of duplication + new transport

pigmej added a commit that referenced this pull request Dec 11, 2015
@pigmej pigmej merged commit 7d12e56 into Mirantis:master Dec 11, 2015
@pigmej
Copy link
Contributor

pigmej commented Dec 11, 2015

gevent was not added in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants