Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve info about virtlet installation validation #538

Merged
merged 2 commits into from
Dec 22, 2017

Conversation

jellonek
Copy link
Contributor

@jellonek jellonek commented Dec 21, 2017

This change is Reviewable

@ivan4th
Copy link
Contributor

ivan4th commented Dec 22, 2017

Review status: 0 of 3 files reviewed at latest revision, 7 unresolved discussions.


deploy/real-cluster.md, line 80 at r1 (raw file):

Escape character is ^]

### Validation of ssh access to pod

Verifying ssh access to a VM pod


deploy/real-cluster.md, line 97 at r1 (raw file):

Validation of pod access to cluster services

Verifying accessing services from a VM pod


deploy/real-cluster.md, line 101 at r1 (raw file):

After connecting to VM using one of above method you can validate VM access to
cluster services. Use below command to display an IP address of kubernetes
api service:

After connecting to the VM using one of the above methods you can check access from the VM to cluster services. To check DNS resolution of cluster services, use the following command:


deploy/real-cluster.md, line 107 at r1 (raw file):

Use below command to try to access this service:

The following command may be used to check service connectivity (note that it'll give you an authentication error):


deploy/real-cluster.md, line 113 at r1 (raw file):

Using the same method you can verify access to any service from internet, e.x.:

You can also verify Internet access from the VM:


deploy/real-cluster.md, line 116 at r1 (raw file):

curl -k https://google.com

Also add ping -c 1 8.8.8.8


deploy/real-cluster.md, line 117 at r1 (raw file):

curl -k https://google.com

If you have Kubernetes Dashboard installed (it's present in kubeadm-dind-cluster installations for example), you can check dashboard access using this command:

curl http://kubernetes-dashboard.kube-system.svc.cluster.local

This should display some html from the dashboard's main page.


Comments from Reviewable

@jellonek jellonek force-pushed the jell/installation_validation branch 2 times, most recently from 1405662 to 246f764 Compare December 22, 2017 12:32
@jellonek
Copy link
Contributor Author

Review status: 0 of 3 files reviewed at latest revision, 7 unresolved discussions.


deploy/real-cluster.md, line 80 at r1 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

Verifying ssh access to a VM pod

Done.


deploy/real-cluster.md, line 101 at r1 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

After connecting to the VM using one of the above methods you can check access from the VM to cluster services. To check DNS resolution of cluster services, use the following command:

Done.


deploy/real-cluster.md, line 107 at r1 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

The following command may be used to check service connectivity (note that it'll give you an authentication error):

Done.


deploy/real-cluster.md, line 113 at r1 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

You can also verify Internet access from the VM:

Done.


deploy/real-cluster.md, line 116 at r1 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

Also add ping -c 1 8.8.8.8

Done.


deploy/real-cluster.md, line 117 at r1 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

If you have Kubernetes Dashboard installed (it's present in kubeadm-dind-cluster installations for example), you can check dashboard access using this command:

curl http://kubernetes-dashboard.kube-system.svc.cluster.local

This should display some html from the dashboard's main page.

Done.


Comments from Reviewable

@ivan4th
Copy link
Contributor

ivan4th commented Dec 22, 2017

Reviewed 1 of 3 files at r1.
Review status: 1 of 3 files reviewed at latest revision, 1 unresolved discussion.


deploy/real-cluster.md, line 55 at r2 (raw file):

## Testing the installation

### Validation of basic pod starting

Sorry, missed this one. Should be "Checking basic pod startup"


Comments from Reviewable

@jellonek
Copy link
Contributor Author

Reviewed 1 of 3 files at r1, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


deploy/real-cluster.md, line 97 at r1 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

Verifying accessing services from a VM pod

Done.


deploy/real-cluster.md, line 55 at r2 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

Sorry, missed this one. Should be "Checking basic pod startup"

Done.


Comments from Reviewable

@ivan4th
Copy link
Contributor

ivan4th commented Dec 22, 2017

Reviewed 1 of 3 files at r1, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@ivan4th
Copy link
Contributor

ivan4th commented Dec 22, 2017

:lgtm:


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@ologvinova
Copy link
Contributor

:lgtm:


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jellonek jellonek merged commit 515af67 into master Dec 22, 2017
@jellonek jellonek deleted the jell/installation_validation branch December 22, 2017 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants