fix: miscellanous NanoSocket bits and pieces, add Mirage Standalone support #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Oct 8, 2022
## [128.4.1](v128.4.0...v128.4.1) (2022-10-08) ### Bug Fixes * miscellanous NanoSocket bits and pieces, add Mirage Standalone support ([#1106](#1106)) ([1b7e097](1b7e097))
|
🎉 This PR is included in version 128.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a multi-commit PR that addresses a few things:
isWebglis nowisWebGL). This is more just for cosmetic appearance, and these were used internally and not outside of the Mirage Sockets' layer.#if UNITY_EDITOR || UNITY_STANDALONEdefines in the NanoSockets source files or the Mirage Standalone project would complain.isDesktopto point to a boolean-returning function instead of a expression for Mirage Standalone compatibility.Tested briefly on Windows instance of the Unity Editor version 2020.3.38. Shouldn't break anything, I hope.