Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: errors and warnings on 2023.1 alpha #1120

Merged
merged 3 commits into from
Dec 22, 2022

Conversation

Hertzole
Copy link
Contributor

A fresh install of Mirage on the 2023.1 alpha caused a few issues:

  • Compilation issues due to ambiguous matches between UniTask's GetAwaiter and Unity's new Awaitable GetAwaiter
  • Depcreation warning as Object.FindObjectOfType is now deprecated

I fixed these using the following methods:

  • Update the UniTask dependency to 2.3.3 (the ambiguous match was fixed in UniTask 2.3.2
  • Added #if define in EditorLogSettingsLoader to use the new Object.FindFirstObjectOfType

I have not updated any tests to remove any warnings when in 2023.1, but I could if desired.

@James-Frowen James-Frowen merged commit 37fa113 into MirageNet:master Dec 22, 2022
@Hertzole Hertzole deleted the 2023_update branch December 22, 2022 19:34
github-actions bot pushed a commit that referenced this pull request Dec 22, 2022
## [129.3.2](v129.3.1...v129.3.2) (2022-12-22)

### Bug Fixes

* errors and warnings on 2023.1 alpha ([#1120](#1120)) ([37fa113](37fa113))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 129.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants