fix(SyncList): Change Callback to Action

MirrorNetworking · Mar 23, 2024 · f2b8986 · f2b8986
1 parent f2d43de
commit f2b8986
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/Assets/Mirror/Core/SyncList.cs b/Assets/Mirror/Core/SyncList.cs
@@ -15,8 +15,7 @@ public enum Operation : byte
             OP_CLEAR
         }
 
-        public delegate void SyncListChanged(Operation op, int itemIndex, T oldItem, T newItem);
-        public event SyncListChanged Callback;
+        public Action<Operation, int, T, T> Callback;
 
         readonly IList<T> objects;
         readonly IEqualityComparer<T> comparer;

diff --git a/Assets/Mirror/Tests/Editor/SyncCollections/SyncListStructTest.cs b/Assets/Mirror/Tests/Editor/SyncCollections/SyncListStructTest.cs
@@ -48,7 +48,7 @@ public void OldValueShouldNotBeNewValue()
             serverList[0] = player;
 
             bool callbackCalled = false;
-            clientList.Callback += (SyncList<TestPlayer>.Operation op, int itemIndex, TestPlayer oldItem, TestPlayer newItem) =>
+            clientList.Callback = (SyncList<TestPlayer>.Operation op, int itemIndex, TestPlayer oldItem, TestPlayer newItem) =>
             {
                 Assert.That(op == SyncList<TestPlayer>.Operation.OP_SET, Is.True);
                 Assert.That(itemIndex, Is.EqualTo(0));

diff --git a/Assets/Mirror/Tests/Editor/SyncCollections/SyncListTest.cs b/Assets/Mirror/Tests/Editor/SyncCollections/SyncListTest.cs
@@ -278,7 +278,7 @@ public void CallbackTest()
         {
             bool called = false;
 
-            clientSyncList.Callback += (op, index, oldItem, newItem) =>
+            clientSyncList.Callback = (op, index, oldItem, newItem) =>
             {
                 called = true;
 
@@ -299,7 +299,7 @@ public void CallbackRemoveTest()
         {
             bool called = false;
 
-            clientSyncList.Callback += (op, index, oldItem, newItem) =>
+            clientSyncList.Callback = (op, index, oldItem, newItem) =>
             {
                 called = true;
 
@@ -318,7 +318,7 @@ public void CallbackRemoveAtTest()
         {
             bool called = false;
 
-            clientSyncList.Callback += (op, index, oldItem, newItem) =>
+            clientSyncList.Callback = (op, index, oldItem, newItem) =>
             {
                 called = true;