Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadyMessage spam -> forced observer rebuilds #2623

Open
imerr opened this issue Mar 10, 2021 · 0 comments
Open

ReadyMessage spam -> forced observer rebuilds #2623

imerr opened this issue Mar 10, 2021 · 0 comments
Labels
bug Something isn't working security

Comments

@imerr
Copy link
Contributor

imerr commented Mar 10, 2021

Describe the bug
A malicious client can send as many ReadyMessages as they want and cause observers to be rebuilt every time (potentially slow):
https://github.com/vis2k/Mirror/blob/64f247fb32e49e833f4e243ef051056cd3a056df/Assets/Mirror/Runtime/NetworkManager.cs#L1073-L1078
https://github.com/vis2k/Mirror/blob/64f247fb32e49e833f4e243ef051056cd3a056df/Assets/Mirror/Runtime/NetworkManager.cs#L1176-L1184
https://github.com/vis2k/Mirror/blob/64f247fb32e49e833f4e243ef051056cd3a056df/Assets/Mirror/Runtime/NetworkServer.cs#L668-L678

Expected behavior
NetworkServer.SetClientReady should return early if isReady is already true (this might break stuff, I'm not too familiar with the ready part of the code)
@miwarnec miwarnec added security bug Something isn't working labels Mar 10, 2021
miwarnec added a commit that referenced this issue Jan 29, 2023
@miwarnec
fix: #2623 NetworkServer.SetClientReady returns if already ready. fix…
8d7f689 
…es clients spamming ReadyMessage to force observer rebuilds etc. [imer]
miwarnec added a commit that referenced this issue Jan 29, 2023
@miwarnec
fix: #2623 NetworkServer.SetClientReady returns if already ready. fix…
564b6f4 
…es clients spamming ReadyMessage to force observer rebuilds etc. [imer]
@miwarnec miwarnec reopened this Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imerr @miwarnec