fix: #1278 - only call initial state SyncVar hooks on clients if the SyncVar value is different from the default one.

[miwarnec]

Weaver generated code before: (see OnDeserialize initialState case!)

public class Test : NetworkBehaviour
{
    [SyncVar(hook = "OnSetA")]
    public int a;

    [SyncVar(hook = "OnSetC")]
    public int c;

    [SyncVar(hook = "OnSetQ")]
    public GameObject q;

    [SyncVar(hook = "OnSetR")]
    public GameObject r;

    private uint ___qNetId;

    private uint ___rNetId;

    public int Networka
    {
        get
        {
            return a;
        }
        [param: In]
        set
        {
            if (!SyncVarEqual(value, ref a))
            {
                if (NetworkServer.localClientActive && !getSyncVarHookGuard(1uL))
                {
                    setSyncVarHookGuard(1uL, value: true);
                    OnSetA(value);
                    setSyncVarHookGuard(1uL, value: false);
                }
                SetSyncVar(value, ref a, 1uL);
            }
        }
    }

    public int Networkc
    {
        get
        {
            return c;
        }
        [param: In]
        set
        {
            if (!SyncVarEqual(value, ref c))
            {
                if (NetworkServer.localClientActive && !getSyncVarHookGuard(2uL))
                {
                    setSyncVarHookGuard(2uL, value: true);
                    OnSetC(value);
                    setSyncVarHookGuard(2uL, value: false);
                }
                SetSyncVar(value, ref c, 2uL);
            }
        }
    }

    public GameObject Networkq
    {
        get
        {
            return GetSyncVarGameObject(___qNetId, ref q);
        }
        [param: In]
        set
        {
            if (!SyncVarGameObjectEqual(value, ___qNetId))
            {
                if (NetworkServer.localClientActive && !getSyncVarHookGuard(4uL))
                {
                    setSyncVarHookGuard(4uL, value: true);
                    OnSetQ(value);
                    setSyncVarHookGuard(4uL, value: false);
                }
                SetSyncVarGameObject(value, ref q, 4uL, ref ___qNetId);
            }
        }
    }

    public GameObject Networkr
    {
        get
        {
            return GetSyncVarGameObject(___rNetId, ref r);
        }
        [param: In]
        set
        {
            if (!SyncVarGameObjectEqual(value, ___rNetId))
            {
                if (NetworkServer.localClientActive && !getSyncVarHookGuard(8uL))
                {
                    setSyncVarHookGuard(8uL, value: true);
                    OnSetR(value);
                    setSyncVarHookGuard(8uL, value: false);
                }
                SetSyncVarGameObject(value, ref r, 8uL, ref ___rNetId);
            }
        }
    }

    private void OnSetA(int newValue)
    {
        Debug.LogWarning((object)$"OnSetA {newValue}");
    }

    private void OnSetC(int newValue)
    {
        Debug.LogWarning((object)$"OnSetC {newValue}");
    }

    private void OnSetQ(GameObject newValue)
    {
        Debug.LogWarning((object)$"OnSetQ {newValue}");
    }

    private void OnSetR(GameObject newValue)
    {
        Debug.LogWarning((object)$"OnSetR {newValue}");
    }

    public override void OnStartServer()
    {
        Networkc = 2;
        Networkr = ((Component)this).get_gameObject();
    }

    private void MirrorProcessed()
    {
    }

    public override bool OnSerialize(NetworkWriter writer, bool forceAll)
    {
        bool result = base.OnSerialize(writer, forceAll);
        if (forceAll)
        {
            writer.WritePackedInt32(a);
            writer.WritePackedInt32(c);
            writer.WriteGameObject(Networkq);
            writer.WriteGameObject(Networkr);
            return true;
        }
        writer.WritePackedUInt64(base.syncVarDirtyBits);
        if ((base.syncVarDirtyBits & 1L) != 0L)
        {
            writer.WritePackedInt32(a);
            result = true;
        }
        if ((base.syncVarDirtyBits & 2L) != 0L)
        {
            writer.WritePackedInt32(c);
            result = true;
        }
        if ((base.syncVarDirtyBits & 4L) != 0L)
        {
            writer.WriteGameObject(Networkq);
            result = true;
        }
        if ((base.syncVarDirtyBits & 8L) != 0L)
        {
            writer.WriteGameObject(Networkr);
            result = true;
        }
        return result;
    }

    public override void OnDeserialize(NetworkReader reader, bool initialState)
    {
        base.OnDeserialize(reader, initialState);
        if (initialState)
        {
            int num = reader.ReadPackedInt32();
            OnSetA(num);
            Networka = num;

            int num2 = reader.ReadPackedInt32();
            OnSetC(num2);
            Networkc = num2;

            uint num3 = reader.ReadPackedUInt32();
            OnSetQ(GetSyncVarGameObject(num3, ref q));
            ___qNetId = num3;

            uint num4 = reader.ReadPackedUInt32();
            OnSetR(GetSyncVarGameObject(num4, ref r));
            ___rNetId = num4;

            return;
        }
        long num5 = (long)reader.ReadPackedUInt64();
        if ((num5 & 1L) != 0L)
        {
            int num6 = reader.ReadPackedInt32();
            OnSetA(num6);
            Networka = num6;
        }
        if ((num5 & 2L) != 0L)
        {
            int num7 = reader.ReadPackedInt32();
            OnSetC(num7);
            Networkc = num7;
        }
        if ((num5 & 4L) != 0L)
        {
            uint num8 = reader.ReadPackedUInt32();
            OnSetQ(GetSyncVarGameObject(num8, ref q));
            ___qNetId = num8;
        }
        if ((num5 & 8L) != 0L)
        {
            uint num9 = reader.ReadPackedUInt32();
            OnSetR(GetSyncVarGameObject(num9, ref r));
            ___rNetId = num9;
        }
    }
}

After:

// Test
using Mirror;
using System.Runtime.InteropServices;
using UnityEngine;

public class Test : NetworkBehaviour
{
    [SyncVar(hook = "OnSetA")]
    public int a;

    [SyncVar(hook = "OnSetC")]
    public int c;

    [SyncVar(hook = "OnSetQ")]
    public GameObject q;

    [SyncVar(hook = "OnSetR")]
    public GameObject r;

    private uint ___qNetId;

    private uint ___rNetId;

    public int Networka
    {
        get
        {
            return a;
        }
        [param: In]
        set
        {
            if (!SyncVarEqual(value, ref a))
            {
                if (NetworkServer.localClientActive && !getSyncVarHookGuard(1uL))
                {
                    setSyncVarHookGuard(1uL, value: true);
                    OnSetA(value);
                    setSyncVarHookGuard(1uL, value: false);
                }
                SetSyncVar(value, ref a, 1uL);
            }
        }
    }

    public int Networkc
    {
        get
        {
            return c;
        }
        [param: In]
        set
        {
            if (!SyncVarEqual(value, ref c))
            {
                if (NetworkServer.localClientActive && !getSyncVarHookGuard(2uL))
                {
                    setSyncVarHookGuard(2uL, value: true);
                    OnSetC(value);
                    setSyncVarHookGuard(2uL, value: false);
                }
                SetSyncVar(value, ref c, 2uL);
            }
        }
    }

    public GameObject Networkq
    {
        get
        {
            return GetSyncVarGameObject(___qNetId, ref q);
        }
        [param: In]
        set
        {
            if (!SyncVarGameObjectEqual(value, ___qNetId))
            {
                if (NetworkServer.localClientActive && !getSyncVarHookGuard(4uL))
                {
                    setSyncVarHookGuard(4uL, value: true);
                    OnSetQ(value);
                    setSyncVarHookGuard(4uL, value: false);
                }
                SetSyncVarGameObject(value, ref q, 4uL, ref ___qNetId);
            }
        }
    }

    public GameObject Networkr
    {
        get
        {
            return GetSyncVarGameObject(___rNetId, ref r);
        }
        [param: In]
        set
        {
            if (!SyncVarGameObjectEqual(value, ___rNetId))
            {
                if (NetworkServer.localClientActive && !getSyncVarHookGuard(8uL))
                {
                    setSyncVarHookGuard(8uL, value: true);
                    OnSetR(value);
                    setSyncVarHookGuard(8uL, value: false);
                }
                SetSyncVarGameObject(value, ref r, 8uL, ref ___rNetId);
            }
        }
    }

    private void OnSetA(int newValue)
    {
        Debug.LogWarning((object)$"OnSetA {newValue}");
    }

    private void OnSetC(int newValue)
    {
        Debug.LogWarning((object)$"OnSetC {newValue}");
    }

    private void OnSetQ(GameObject newValue)
    {
        Debug.LogWarning((object)$"OnSetQ {newValue}");
    }

    private void OnSetR(GameObject newValue)
    {
        Debug.LogWarning((object)$"OnSetR {newValue}");
    }

    public override void OnStartServer()
    {
        Networkc = 2;
        Networkr = ((Component)this).get_gameObject();
    }

    private void MirrorProcessed()
    {
    }

    public override bool OnSerialize(NetworkWriter writer, bool forceAll)
    {
        bool result = base.OnSerialize(writer, forceAll);
        if (forceAll)
        {
            writer.WritePackedInt32(a);
            writer.WritePackedInt32(c);
            writer.WriteGameObject(Networkq);
            writer.WriteGameObject(Networkr);
            return true;
        }
        writer.WritePackedUInt64(base.syncVarDirtyBits);
        if ((base.syncVarDirtyBits & 1L) != 0L)
        {
            writer.WritePackedInt32(a);
            result = true;
        }
        if ((base.syncVarDirtyBits & 2L) != 0L)
        {
            writer.WritePackedInt32(c);
            result = true;
        }
        if ((base.syncVarDirtyBits & 4L) != 0L)
        {
            writer.WriteGameObject(Networkq);
            result = true;
        }
        if ((base.syncVarDirtyBits & 8L) != 0L)
        {
            writer.WriteGameObject(Networkr);
            result = true;
        }
        return result;
    }

    public override void OnDeserialize(NetworkReader reader, bool initialState)
    {
        base.OnDeserialize(reader, initialState);
        if (initialState)
        {
            int num = reader.ReadPackedInt32();
            if (!SyncVarEqual(num, ref a))
            {
                OnSetA(num);
            }
            Networka = num;
            int num2 = reader.ReadPackedInt32();
            if (!SyncVarEqual(num2, ref c))
            {
                OnSetC(num2);
            }
            Networkc = num2;
            uint num3 = reader.ReadPackedUInt32();
            if (!SyncVarEqual(num3, ref ___qNetId))
            {
                OnSetQ(GetSyncVarGameObject(num3, ref q));
            }
            ___qNetId = num3;
            uint num4 = reader.ReadPackedUInt32();
            if (!SyncVarEqual(num4, ref ___rNetId))
            {
                OnSetR(GetSyncVarGameObject(num4, ref r));
            }
            ___rNetId = num4;
            return;
        }
        long num5 = (long)reader.ReadPackedUInt64();
        if ((num5 & 1L) != 0L)
        {
            int num6 = reader.ReadPackedInt32();
            if (!SyncVarEqual(num6, ref a))
            {
                OnSetA(num6);
            }
            Networka = num6;
        }
        if ((num5 & 2L) != 0L)
        {
            int num7 = reader.ReadPackedInt32();
            if (!SyncVarEqual(num7, ref c))
            {
                OnSetC(num7);
            }
            Networkc = num7;
        }
        if ((num5 & 4L) != 0L)
        {
            uint num8 = reader.ReadPackedUInt32();
            if (!SyncVarEqual(num8, ref ___qNetId))
            {
                OnSetQ(GetSyncVarGameObject(num8, ref q));
            }
            ___qNetId = num8;
        }
        if ((num5 & 8L) != 0L)
        {
            uint num9 = reader.ReadPackedUInt32();
            if (!SyncVarEqual(num9, ref ___rNetId))
            {
                OnSetR(GetSyncVarGameObject(num9, ref r));
            }
            ___rNetId = num9;
        }
    }
}