Breaking: Renamed localEulerAnglesSensitivity #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why rename it? |
|
This is a breaking change |
He is renaming it from localeulerangle to local rotation sensitivity, not the other way around |
@vis2k What he said ^ |
MrGadget1024
changed the title
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Feb 6, 2020
# [8.0.0](7.0.0-master...8.0.0-master) (2020-02-06) ### Bug Fixes * call callback after update dictionary in host ([#1476](https://github.com/MirrorNG/MirrorNG/issues/1476)) ([1736bb0](1736bb0)) * port network discovery ([d6a1154](d6a1154)) * remove scriptableobject error Tests ([479b78b](479b78b)) * Telepathy reverted to older version to fix freezes when calling Client.Disconnect on some platforms like Windows 10 ([d0d77b6](d0d77b6)) * Telepathy updated to latest version. Threads are closed properly now. ([4007423](4007423)) * Renamed localEulerAnglesSensitivity (#1474) ([eee9692](eee9692)), closes [#1474](https://github.com/MirrorNG/MirrorNG/issues/1474) ### breaking * Transports can now provide their Uri ([#1454](https://github.com/MirrorNG/MirrorNG/issues/1454)) ([b916064](b916064)), closes [#38](#38) ### Features * Implemented NetworkReaderPool ([#1464](https://github.com/MirrorNG/MirrorNG/issues/1464)) ([9257112](9257112)) * LAN Network discovery ([#1453](https://github.com/MirrorNG/MirrorNG/issues/1453)) ([e75b45f](e75b45f)), closes [#38](#38) * Mirror Icon for all components ([#1452](https://github.com/MirrorNG/MirrorNG/issues/1452)) ([a7efb13](a7efb13)) * supports scriptable objects ([4b8f819](4b8f819)) ### BREAKING CHANGES * localEulerAnglesSensitivity renamed to localRotationSensitivity * Make the server uri method mandatory in transports Co-authored-by: MrGadget <chris@clevertech.net>
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Feb 6, 2020
BREAKING CHANGE: localEulerAnglesSensitivity renamed to localRotationSensitivity
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Feb 6, 2020
# [8.0.0](7.0.0-master...8.0.0-master) (2020-02-06) ### Bug Fixes * call callback after update dictionary in host ([#1476](https://github.com/MirrorNG/MirrorNG/issues/1476)) ([1736bb0](1736bb0)) * port network discovery ([d6a1154](d6a1154)) * remove scriptableobject error Tests ([479b78b](479b78b)) * Telepathy reverted to older version to fix freezes when calling Client.Disconnect on some platforms like Windows 10 ([d0d77b6](d0d77b6)) * Telepathy updated to latest version. Threads are closed properly now. ([4007423](4007423)) * Renamed localEulerAnglesSensitivity (#1474) ([eee9692](eee9692)), closes [#1474](https://github.com/MirrorNG/MirrorNG/issues/1474) ### breaking * Transports can now provide their Uri ([#1454](https://github.com/MirrorNG/MirrorNG/issues/1454)) ([b916064](b916064)), closes [#38](#38) ### Features * Implemented NetworkReaderPool ([#1464](https://github.com/MirrorNG/MirrorNG/issues/1464)) ([9257112](9257112)) * LAN Network discovery ([#1453](https://github.com/MirrorNG/MirrorNG/issues/1453)) ([e75b45f](e75b45f)), closes [#38](#38) * Mirror Icon for all components ([#1452](https://github.com/MirrorNG/MirrorNG/issues/1452)) ([a7efb13](a7efb13)) * supports scriptable objects ([4b8f819](4b8f819)) ### BREAKING CHANGES * localEulerAnglesSensitivity renamed to localRotationSensitivity * Make the server uri method mandatory in transports Co-authored-by: MrGadget <chris@clevertech.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was only added 2 weeks ago, so I think the rename is safe without an obsolete.