Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: InterestManagementBase #3379

Merged
merged 2 commits into from
Feb 16, 2023
Merged

feat: InterestManagementBase #3379

merged 2 commits into from
Feb 16, 2023

Conversation

imerr
Copy link
Contributor

@imerr imerr commented Feb 14, 2023

A low level interest management base class that allows more advanced interest management by bypassing the built-in HashSet checks
Full compatibility with existing interest management classes is preserved, this is technically a breaking change since NetworkServer.aoi/NetworkClient.aoi is a different type (but with same api), but that is the only breaking change I can think of

See previous PR #2764
See also #2581 (comment)

@imerr
Copy link
Contributor Author

imerr commented Feb 14, 2023

See #3380 for a WIP spatial hashing interest management
In my past testing, it's 4x faster for me
In @ninjakickja's recent testing ("simulation") it's 2.5x faster than the current one

@MrGadget1024
Copy link
Collaborator

MrGadget1024 commented Feb 16, 2023

I don't think this is a breaking change because none of the public methods or properties of aoi are changed. Anyone who was referencing aoi will not notice any difference, because IM inherits from LLIM so strong typing in user code would hold up.

image

@imerr imerr changed the title feat: LowLevelInterestManagement feat: InterestManagementBase Feb 16, 2023
@imerr imerr force-pushed the feat/llaoi branch 4 times, most recently from 5750978 to a7e8b19 Compare February 16, 2023 11:22
A interest management base class that allows more advanced interest management by bypassing the built-in HashSet checks via Rebuild overriding
@miwarnec miwarnec merged commit b933dcb into master Feb 16, 2023
@miwarnec miwarnec deleted the feat/llaoi branch February 16, 2023 11:57
MrGadget1024 pushed a commit that referenced this pull request Feb 16, 2023
* feat: InterestManagementBase

A interest management base class that allows more advanced interest management by bypassing the built-in HashSet checks via Rebuild overriding

* Update Assets/Mirror/Core/InterestManagementBase.cs

---------

Co-authored-by: mischa <16416509+vis2k@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants