Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: allow NetworkBehaviour components in children. solves #2276 #3486

Merged
merged 10 commits into from May 27, 2023

Conversation

miwarnec
Copy link
Collaborator

@miwarnec miwarnec commented May 14, 2023

TODO

  • ensure NetworkBehaviours still require NetworkIdentities in parents: image
  • ensure NetworkIdentities can't have NetworkIdentity children. This is already checked:
    image
  • demos (tanks ?)
  • test coverage: simple test to ensure child NBs [SyncVar]s are included etc.
    image
  • docs
  • announcement

this has been requested a lot: #2276

@miwarnec miwarnec changed the title feature: allow child NetworkBehaviour components in children feature: allow child NetworkBehaviour components in children. solves #2276 May 14, 2023
Copy link
Collaborator

@MrGadget1024 MrGadget1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always add missing NI

@miwarnec miwarnec marked this pull request as ready for review May 23, 2023 02:53
@miwarnec miwarnec changed the title feature: allow child NetworkBehaviour components in children. solves #2276 feature: allow NetworkBehaviour components in children. solves #2276 May 24, 2023
@miwarnec miwarnec merged commit 18eda4d into master May 27, 2023
1 of 5 checks passed
@miwarnec miwarnec deleted the child_nbs branch May 27, 2023 00:03
miwarnec added a commit that referenced this pull request May 27, 2023
…3486)

* feature: allow child NetworkBehaviour components in children

* Tanks demo: move Turret NetworkTransform to child

* NT TODO

* RequireInParents NI

* NetworkAnimatore allow in children

* call base onvalidate

* Add OnValidate to Script Template

* fix for pre-2020.3 Unity

* MirrorTest: CreateNetworked with NetworkBehaviour in children

* Tests: child networkbehaviours

---------

Co-authored-by: MrGadget1024 <9826063+MrGadget1024@users.noreply.github.com>
miwarnec added a commit that referenced this pull request May 27, 2023
…3486)

* feature: allow child NetworkBehaviour components in children

* Tanks demo: move Turret NetworkTransform to child

* NT TODO

* RequireInParents NI

* NetworkAnimatore allow in children

* call base onvalidate

* Add OnValidate to Script Template

* fix for pre-2020.3 Unity

* MirrorTest: CreateNetworked with NetworkBehaviour in children

* Tests: child networkbehaviours

---------

Co-authored-by: MrGadget1024 <9826063+MrGadget1024@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants