New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: allow NetworkBehaviour components in children. solves #2276 #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miwarnec
changed the title
feature: allow child NetworkBehaviour components in children
feature: allow child NetworkBehaviour components in children. solves #2276
May 14, 2023
MrGadget1024
requested changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always add missing NI
miwarnec
changed the title
feature: allow child NetworkBehaviour components in children. solves #2276
feature: allow NetworkBehaviour components in children. solves #2276
May 24, 2023
miwarnec
added a commit
that referenced
this pull request
May 27, 2023
…3486) * feature: allow child NetworkBehaviour components in children * Tanks demo: move Turret NetworkTransform to child * NT TODO * RequireInParents NI * NetworkAnimatore allow in children * call base onvalidate * Add OnValidate to Script Template * fix for pre-2020.3 Unity * MirrorTest: CreateNetworked with NetworkBehaviour in children * Tests: child networkbehaviours --------- Co-authored-by: MrGadget1024 <9826063+MrGadget1024@users.noreply.github.com>
miwarnec
added a commit
that referenced
this pull request
May 27, 2023
…3486) * feature: allow child NetworkBehaviour components in children * Tanks demo: move Turret NetworkTransform to child * NT TODO * RequireInParents NI * NetworkAnimatore allow in children * call base onvalidate * Add OnValidate to Script Template * fix for pre-2020.3 Unity * MirrorTest: CreateNetworked with NetworkBehaviour in children * Tests: child networkbehaviours --------- Co-authored-by: MrGadget1024 <9826063+MrGadget1024@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
this has been requested a lot: #2276