Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #3576 Pings are now stamped with a scene hash so we can drop messages before a (potentially long) scene load. fixes a bug where RTT would be very high after a long scene load. #3650

Merged
merged 2 commits into from
Nov 15, 2023
Merged

fix: #3576 Pings are now stamped with a scene hash so we can drop messages before a (potentially long) scene load. fixes a bug where RTT would be very high after a long scene load. #3650

merged 2 commits into from
Nov 15, 2023

Conversation

miwarnec
Copy link
Collaborator

@miwarnec miwarnec commented Nov 15, 2023 •
edited

fix for #3576

  • resetting statics isn't enough, we still get ~50 ping messages from the previous scene
  • those need to be ignored, hence the scene hash
  • with this, ping doesn't drop a beat. super consistent even through scene changes.

@miwarnec
fix: #3576 Pings are now stamped with a scene hash so we can drop mes…
f76107c 
…sages before a (potentially long) scene load. fixes a bug where RTT would be very high after a long scene load.
@miwarnec
16 bit hash fakebyte
54da877
@miwarnec miwarnec merged commit c729fe1 into master Nov 15, 2023
7 checks passed
@miwarnec miwarnec deleted the fix_3576 branch November 15, 2023 10:25
miwarnec added a commit that referenced this pull request Nov 17, 2023
@miwarnec
Revert "fix: #3576 Pings are now stamped with a scene hash so we can …
d34a046 
…drop messages before a (potentially long) scene load. fixes a bug where RTT would be very high after a long scene load. (#3650)"

This reverts commit c729fe1.
miwarnec added a commit that referenced this pull request Nov 17, 2023
@miwarnec
fix: #3576 Pings are now stamped with a scene hash so we can drop mes…
26ae2be 
…sages before a (potentially long) scene load. fixes a bug where RTT would be very high after a long scene load. (#3650)

* fix: #3576 Pings are now stamped with a scene hash so we can drop messages before a (potentially long) scene load. fixes a bug where RTT would be very high after a long scene load.

* 16 bit hash fakebyte
miwarnec added a commit that referenced this pull request Nov 17, 2023
@miwarnec
Revert "fix: #3576 Pings are now stamped with a scene hash so we can …
816b775 
…drop messages before a (potentially long) scene load. fixes a bug where RTT would be very high after a long scene load. (#3650)"

This reverts commit c729fe1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@miwarnec