Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some modules do not render correctly in module browser #44

Open
cschol opened this issue Jul 6, 2019 · 0 comments
Open

Some modules do not render correctly in module browser #44

cschol opened this issue Jul 6, 2019 · 0 comments

Comments

@cschol
Copy link
Contributor

cschol commented Jul 6, 2019

Some modules do not render their display component in the module browser.

For example, EssEff:

image

As you can see, the display component is missing. Same for ChordSeq and all other modules using a custom display component.

The issue is the way you instantiate the display component:

Your EssEffWidget checks if module is non-NULL at the top-level and if it is not (for example in the module browser) it does not render the display widgets.

What you should be doing is passing the module pointer to the display widget and then checking validity of the pointer inside of the display widget. If it is not valid (which in your case means you don't have access to a file name) you draw the widget appropriately, for example using a "-" as a file name or an empty string. Then the widget is rendered correctly.

You can look at "AudibleInstruments - Braids" for an example.

This applies to all of your modules that use a custom display widget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant