Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RJModules #507

Closed
Miserlou opened this issue Sep 9, 2018 · 55 comments
Closed

RJModules #507

Miserlou opened this issue Sep 9, 2018 · 55 comments

Comments

@Miserlou
Copy link

Miserlou commented Sep 9, 2018

{
  "name": "RJModules",
  "author": "Miserlou (Rich Jones)",
  "license": "BSD-3-Clause",
  "manualUrl": "https://github.com/Miserlou/RJModules/blob/master/README.md",
  "sourceUrl": "https://github.com/Miserlou/RJModules",
  "latestVersion": "0.6.1",
  "status": "available"
}

New modules:

  • Chord
  • ChordSeq
  • Glides
  • Octaves
  • Buffers
  • RandomFilter
@AndrewBelt AndrewBelt changed the title RJModules 0.6.1 RJModules Sep 9, 2018
@AndrewBelt
Copy link
Member

Updated build

@cschol cschol added this to Plugin integration in v0.6 plugins May 8, 2019
@cschol cschol moved this from Plugin integration to Plugin available for v0.6 in v0.6 plugins May 8, 2019
@cschol cschol added this to Needs review in VCV Rack Open-source Plugins Jun 28, 2019
@Miserlou
Copy link
Author

My migration to 1.0.0+ is complete!

URL: https://github.com/Miserlou/RJModules/
Commit: 4120b4228ce4f5159c1aed24e4c5901f6d1012ce

The major new addition, besides the migration, is 'Acid', my take on the TB-303!

I'd also really really love it if somebody could take a quick look at: Miserlou/RJModules#38 in case anything jumps out at them..

@cschol cschol reopened this Jun 28, 2019
@cschol
Copy link
Collaborator

cschol commented Jun 28, 2019

Invalid tag in plugin.json: Miserlou/RJModules#39
Compile failure on Windows: Miserlou/RJModules#40

@cschol cschol moved this from Needs review to Needs repair/migration in VCV Rack Open-source Plugins Jun 28, 2019
@cschol cschol moved this from Needs repair/migration to Needs review in VCV Rack Open-source Plugins Jun 29, 2019
@cschol cschol moved this from Needs review to Needs repair/migration in VCV Rack Open-source Plugins Jun 29, 2019
@Miserlou
Copy link
Author

Thank you for reporting those! They should be resolved now, although I don't have a windows machine to test on.

@Miserlou
Copy link
Author

Miserlou commented Jul 1, 2019

Okay, the Windows fix (thank you!) and the stability fixes are here, 1.0.0 looks like a go!

@cschol cschol moved this from Needs repair/migration to Needs review in VCV Rack Open-source Plugins Jul 1, 2019
@Miserlou
Copy link
Author

Miserlou commented Jul 3, 2019

Any chance this can get out today? I'd love to have it be available when I publish my tutorial video.

@cschol
Copy link
Collaborator

cschol commented Jul 3, 2019

No crashes anymore, but FYI, this is still an issue: Miserlou/RJModules#41

@Miserlou
Copy link
Author

Miserlou commented Jul 3, 2019 via email

@cschol
Copy link
Collaborator

cschol commented Jul 4, 2019

It's happening on Linux on a non-4K system also, just FYI.

@cschol
Copy link
Collaborator

cschol commented Jul 4, 2019

Updated Miserlou/RJModules#41 with a fix for ChordSeq.

@Miserlou
Copy link
Author

Miserlou commented Jul 5, 2019

Patched.

@Katharsas
Copy link

Katharsas commented Jul 5, 2019

Sorry if this is the wrong place, but for me (windows) VCVRack (1.1.1) does not seem to download this plugin specifically from the Plugin library for some reason (others work) (they also don't show up in the user folder).

@cschol
Copy link
Collaborator

cschol commented Jul 5, 2019

It is not in the plugin manager yet.

@cschol cschol moved this from Needs review to Needs repair/migration in VCV Rack Open-source Plugins Jul 6, 2019
@cschol
Copy link
Collaborator

cschol commented Jul 6, 2019

Splitter has duplicate port IDs: Miserlou/RJModules#43
Widget rendering issues in module browser: Miserlou/RJModules#44

@Miserlou
Copy link
Author

Miserlou commented Jul 6, 2019

Okay, what's actually the policy about blockers here? I appreciate your reports, but I wouldn't consider either of those blockers for 1.0, as it's been a week and they're still not available. One of those issues is only for 1.2+ anyway, and the other one is a minor UI quirk that shows up on a bunch of other modules. This 1.0 migration has already been a massive and unfun time sink, can you please just publish these so I can get my tutorial video out?

@cschol
Copy link
Collaborator

cschol commented Jul 6, 2019

I perform a quality audit of plugins before they are integrated in the plugin manager.

There are certain criteria (for example missing/invalid fields in plugin.json, build failures on a platform, or plugin crashes), that are an automatic blocker. Handling other issues is at my discretion.

If I notice bugs in a module during integration or update, I generally give the developer the chance to fix them because a) it looks unprofessional for the developer and b) it looks unprofessional for the VCV Rack platform if plugins are buggy.

  • The custom displays on your EssEff module are broken on 2/3 platforms (overrun the display widget on Windows and Linux, issue 41). f you want to fix that in the next release I am OK with that.
  • The module browser widget rendering is minor, I agree, but is a fundamental issue in how you wrote the modules. It needs to be fixed. If you want to do that in the next release I am OK with that.
  • Splitter duplicate port root cause was a bug. Port 4 was not available. This has nothing to do with 1.2+ and benefits users right now.

Lastly, if you know of issues in other modules I would appreciate it if you let me know which those are so I can follow up with the developer.

@cschol cschol reopened this Jan 3, 2020
VCV Rack Open-source Plugins automation moved this from Up-to-date to Needs review Jan 3, 2020
@cschol
Copy link
Collaborator

cschol commented Jan 9, 2020

@Miserlou Can you please specify a SHA to build for this plugin? There appear to have been changes since the announcement 6 days ago. Thanks.

@cschol
Copy link
Collaborator

cschol commented Jan 16, 2020

@Miserlou ping

@Miserlou
Copy link
Author

Okay, I just added one more, so let's try version 1.7.0 on commit ID fe87c84, just pushed.

@cschol
Copy link
Collaborator

cschol commented Jan 17, 2020

@Miserlou Did you push the change? I don't see any changes in the repo.

@Miserlou
Copy link
Author

? This guy: Miserlou/RJModules@fe87c84

@cschol
Copy link
Collaborator

cschol commented Jan 18, 2020

Something was borked in me local repo. Got it now.

@cschol cschol moved this from Needs review to Needs build update in VCV Rack Open-source Plugins Jan 18, 2020
VCV Rack Open-source Plugins automation moved this from Needs build update to Up-to-date Jan 18, 2020
@Miserlou
Copy link
Author

Miserlou commented Feb 3, 2020

1.7.2 - Miserlou/RJModules@7db2aad

No new modules, but fixes two major crash-on-add and crash-on-remove bugs which were affecting all non-OSX users.

@cschol cschol reopened this Feb 3, 2020
VCV Rack Open-source Plugins automation moved this from Up-to-date to Needs review Feb 3, 2020
@cschol cschol moved this from Needs review to Needs build update in VCV Rack Open-source Plugins Feb 4, 2020
VCV Rack Open-source Plugins automation moved this from Needs build update to Up-to-date Feb 4, 2020
@Miserlou
Copy link
Author

Miserlou/RJModules@b19ae84

1.8.0 - adds MegaDivider, a giant multiclock divider, and GlutenFree, a crazy granulator.

@cschol cschol reopened this Feb 12, 2020
VCV Rack Open-source Plugins automation moved this from Up-to-date to Needs review Feb 12, 2020
@cschol
Copy link
Collaborator

cschol commented Feb 12, 2020

Gluten crash on multiple platforms: Miserlou/RJModules#73

@cschol cschol moved this from Needs review to Needs repair/migration in VCV Rack Open-source Plugins Feb 12, 2020
@Miserlou
Copy link
Author

Crashes fixed.

@cschol
Copy link
Collaborator

cschol commented Feb 29, 2020

Gluten still crashes. Miserlou/RJModules#73 (commit: eaec41d8f428bc405601a3b29b3a8d4cd50f2246)

@cschol
Copy link
Collaborator

cschol commented Jul 19, 2020

@Miserlou Do you have an update on this issue? If not, I will close it for now. Thanks.

@cschol cschol closed this as completed Jul 28, 2020
VCV Rack Open-source Plugins automation moved this from Needs repair/migration to Up-to-date Jul 28, 2020
@cschol cschol moved this from Up-to-date to Repair/migration in VCV Rack Open-source Plugins Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
v0.6 plugins
Up-to-date, awaiting update from author
Development

No branches or pull requests

5 participants