Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add touch_try_count and raise RequestException #1808

Closed
wants to merge 3 commits into from

Conversation

sebatyler
Copy link

Description

Update for my project using zappa is often failing. It is because of 2 reasons.

  • Downloading dependency is facing read timeout. Message is below.
Downloading and installing dependencies..
 - ruamel.yaml==0.15.60: Downloading
HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Read timed out. (read timeout=2)
  • Checking touch_path is failing. Message is below.
Error: Warning! Status check on the deployed lambda failed. A GET request to '/' yielded a 504 response code.

Fatal error: local() encountered an error (return code 1) while executing 'zappa update prod'

So I want to add 'touch_try_count' setting and raise exception explicitly when request failed.

@sebatyler sebatyler changed the title Improve update Add touch_try_count and raise RequestException Mar 10, 2019
@coveralls
Copy link

coveralls commented Mar 10, 2019

Coverage Status

Coverage decreased (-0.06%) to 72.947% when pulling c4b0677 on sebatyler:improve_update into 2019fe4 on Miserlou:master.

@sebatyler
Copy link
Author

@jneves You approved this PR. Would it be merged? or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants