-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BINARY_SUPPORT to use Content-Encoding to identify if data is binary #2170
Open
monkut
wants to merge
11
commits into
Miserlou:master
Choose a base branch
from
monkut:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jun 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1a51f2e - Browse repository at this point
Copy the full SHA 1a51f2eView commit details
Commits on Jul 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0adb704 - Browse repository at this point
Copy the full SHA 0adb704View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5923b0e - Browse repository at this point
Copy the full SHA 5923b0eView commit details
Commits on Oct 1, 2020
-
Use Content-Encoding to identify if data is binary
When using _whitenoise_ for caching, which provides compression, binary types may include mimetypes, "text/", "application/json": - response.mimetype.startswith("text/") - response.mimetype == "application/json" Assuming that Content-Encoding will be set (as whitenoise apparently does) this allows compression to be applied by the application for "text/" and "application/json". About Content-Encoding: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Encoding
Configuration menu - View commit details
-
Copy full SHA for cd745c8 - Browse repository at this point
Copy the full SHA cd745c8View commit details -
Merge pull request #1 from monkut/supportbinary-with-contentencoding
Use Content-Encoding to identify if data is binary
Configuration menu - View commit details
-
Copy full SHA for b53ccb1 - Browse repository at this point
Copy the full SHA b53ccb1View commit details
Commits on Oct 2, 2020
-
5
Configuration menu - View commit details
-
Copy full SHA for 7f156ae - Browse repository at this point
Copy the full SHA 7f156aeView commit details
Commits on Jan 28, 2021
-
Include fallbacks for cases: - try binary, fail to text - try text, fail to binary
Configuration menu - View commit details
-
Copy full SHA for 6c66a6c - Browse repository at this point
Copy the full SHA 6c66a6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea8f436 - Browse repository at this point
Copy the full SHA ea8f436View commit details -
Configuration menu - View commit details
-
Copy full SHA for 197c906 - Browse repository at this point
Copy the full SHA 197c906View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32293f9 - Browse repository at this point
Copy the full SHA 32293f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14658ce - Browse repository at this point
Copy the full SHA 14658ceView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.