Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump boto3/botocore versions #2193

Closed
wants to merge 2 commits into from

Conversation

ian-whitestone
Copy link

Description

In support of #2188, this PR bumps the versions of boto3/botocore, so that we have access to the new Docker image functionality.

GitHub Issues

Related #2188

Testing

I created a new virtual env with the new dependencies and ran several Zappa workflows: deploy, update, status, and undeploy.

image

image

Any other tests you'd recommend running?

@coveralls
Copy link

coveralls commented Dec 30, 2020

Coverage Status

Coverage remained the same at 72.975% when pulling d455069 on ian-whitestone:bump-reqmts into 542c8c6 on Miserlou:master.

werkzeug==0.16.1 # via -r requirements.in
wheel==0.34.2 # via -r requirements.in
wsgi-request-logger==0.4.6 # via -r requirements.in
zipp==3.4.0 # via importlib-metadata
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the diff is a bit hard to read, here's what actually changed:

updated dependencies:

boto3==1.16.46            # via -r requirements.in, kappa
botocore==1.19.46         # via boto3, s3transfer

new dependencies:

importlib-metadata==1.7.0  # via argcomplete
zipp==3.4.0               # via importlib-metadata

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.16.45 in one requirements file, but 1.16.46 in another?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the requirements.in so it is also 1.16.46, not sure why the inconsistency arose

@ian-whitestone
Copy link
Author

Coverage Status

Coverage decreased (-16.6%) to 56.371% when pulling 6655776 on ian-whitestone:bump-reqmts into 542c8c6 on Miserlou:master.

No idea why coverage dropped, it shouldn't given that i just bumped dependencies. Can we merge even though this is failing (assuming we're ok with everything else?)

@ian-whitestone
Copy link
Author

Coverage Status
Coverage decreased (-16.6%) to 56.371% when pulling 6655776 on ian-whitestone:bump-reqmts into 542c8c6 on Miserlou:master.

No idea why coverage dropped, it shouldn't given that i just bumped dependencies. Can we merge even though this is failing (assuming we're ok with everything else?)

nvm, looks like it is passing now...

@ian-whitestone
Copy link
Author

@jneves would you be able to 👍 or 👎 when you get a chance?

@ian-whitestone
Copy link
Author

@mcrowson any chance you'd be able to 👍 or 👎 ?

requirements.in Outdated Show resolved Hide resolved
@mcrowson
Copy link
Collaborator

I like the change, but can you make it to the zappa/zappa project? I'm not sure how @jneves pulled in the issues or if outstanding MRs got merged too, but make the changes to the other project and tag me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants