Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct parsing of S3 key URI. #375

Merged
merged 1 commit into from Oct 2, 2016
Merged

Correct parsing of S3 key URI. #375

merged 1 commit into from Oct 2, 2016

Conversation

jlevy
Copy link

@jlevy jlevy commented Oct 2, 2016

Fixes #374.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 80.174% when pulling 49aa89b on jlevy:fix-lets-encrypt-s3-parse into a544d04 on Miserlou:dev.

@Miserlou
Copy link
Owner

Miserlou commented Oct 2, 2016

Ugh, good catch. This is still the least-tested part of the project. :(

@Miserlou Miserlou merged commit 48ed024 into Miserlou:dev Oct 2, 2016
@jlevy jlevy deleted the fix-lets-encrypt-s3-parse branch October 3, 2016 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jlevy @coveralls @Miserlou