Add deviceId to Serial parameter of the LibVirt VM definition #202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to link the DeviceIds as you specify them on the Cosmic API to the devices in the OS.
Example:
On the OS, Linux as example:
It seems the max chars a VM will show is 20, even when you put more in the XML:
So
<serial>5-f26f05bc06cc474aa6f7</serial>
becomesvirtio-5-f26f05bc06cc474aa6
. This used to bevirtio-f26f05bc06cc474aa6f7
. As discussed, this is what we want now.