Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deviceId to Serial parameter of the LibVirt VM definition #210

Merged
merged 2 commits into from Jan 9, 2017
Merged

Add deviceId to Serial parameter of the LibVirt VM definition #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53a93ff
Add deviceId to Serial property of Libvirt VmDef
remibergsma Jan 9, 2017
80392f6
Also add Serial with DeviceId when a disk is hot plugged
remibergsma Jan 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ervisor/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
View file
Open in desktop
Expand Up @@ -1912,7 +1912,7 @@ public int compare(final DiskTO arg0, final DiskTO arg1) {

if (data instanceof VolumeObjectTO) {
final VolumeObjectTO volumeObjectTo = (VolumeObjectTO) data;
disk.setSerial(diskUuidToSerial(volumeObjectTo.getUuid()));
disk.setSerial(volumeObjectTo.getDeviceId() + "-" + diskUuidToSerial(volumeObjectTo.getUuid()));
if (volumeObjectTo.getBytesReadRate() != null && volumeObjectTo.getBytesReadRate() > 0) {
disk.setBytesReadRate(volumeObjectTo.getBytesReadRate());
}
Expand Down
2 changes: 1 addition & 1 deletion ...ns/hypervisor/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KvmStorageProcessor.java
View file
Open in desktop
Expand Up @@ -829,7 +829,7 @@ public Answer attachVolume(final AttachCommand cmd) {
final VolumeObjectTO vol = (VolumeObjectTO) disk.getData();
final PrimaryDataStoreTO primaryStore = (PrimaryDataStoreTO) vol.getDataStore();
final String vmName = cmd.getVmName();
final String serial = resource.diskUuidToSerial(vol.getUuid());
final String serial = disk.getDiskSeq() + "-" + resource.diskUuidToSerial(vol.getUuid());
try {
final Connect conn = LibvirtConnection.getConnectionByVmName(vmName);

Expand Down