Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Mark new macros change as potentially breaking
If an OCaml C library already defines some of the new `Val_none`, `Some_val`, `Is_none`, `Is_some`, `caml_alloc_some`, or `Tag_some` macros; then the C compiler will likely warn for macro redefinition, even if the macro definition are identical. This problem happens in [ocaml-mccs][1]. The proposed [fix][2] for libraries is to only define the macros when compiling with OCaml strictly older than 4.12, i.e.: #if OCAML_VERSION < 41200 #define ... #endif [1]: ocaml-opam/ocaml-mccs#30 [2]: ocaml#5154 (comment)
- Loading branch information