A few more tweaks to CardSetApiClient #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think specifying the set id as a uint is much safer and harder to misuse. The Vale API clearly also treats it as a numeric ID since the following are equivalent: |
|
I prefer to match the spec when sending the request at least, which is with the leading 0. I'm ok with the changing the signature to a uint though. |
|
I modified CardSetInfoUrl as per your wishes. |
Rename CardSetDataCache to Cache and make the class generic, so as not to hard code the key/value types. Remove a few unimplemented methods added accidentally by VS.
MisterJimson
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change API to specify set id as an unsigned integer.
Rename CardSetDataCache to Cache and make the class generic, so as not to hard code the key/value types.
Remove a few unimplemented methods added accidentally by VS.