comscore provider #76
Conversation
src/providers/Comscore.js
Outdated
| * | ||
| * @returns {Array} | ||
| */ | ||
| handleCustom(url, params) { |
There was a problem hiding this comment.
I don't think the handleCustom() is even necessary here. Both of the parameters are static and could be mapped in columnMapping() (account already is).
There was a problem hiding this comment.
Can I put the value of the c1 & c2 parameters in a "General" group without using handleCustom? I would like to call them out in their own group as well as putting them in the "Custom" group since I believe they are the only constant, required parameters that do not change between clients, but are still technically "c##" parameters
src/providers/Comscore.js
Outdated
| get columnMapping() { | ||
| return { | ||
| account: "c2", | ||
| requestType: "requestType" |
There was a problem hiding this comment.
I would change this to c1 since it already exists in the keys() :)
There was a problem hiding this comment.
I had the request type mapped in the column as c1, but seeing the "2" looks weird IMO, but I guess if thats what it is, it doesn't matter. Comscore's docs literally say that the c1 parameter is required and describes the event type, but is "prepopulated with a constant value of 2"
|
I just committed. Does it automatically become part of this PR? I simplified things a bit. |
Yup! I'll review here in a bit. Thanks for the work :) |
|
This is live! |
Documentation is sparse on Comscore web pixel, but I've gathered that "c" parameters are custom per client, thus I put them in a custom group. The only exceptions being the c1 parameter is the request type (seems to always be "2") and the c2 parameter is the client's ID. I called these out in a General group. Everything else falls into "Other"