Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Out of bounds array access on caused by unexpected user input to --tunnel #491

Closed
d-e-s-o opened this issue Feb 1, 2022 · 0 comments · Fixed by #550
Closed

Out of bounds array access on caused by unexpected user input to --tunnel #491

d-e-s-o opened this issue Feb 1, 2022 · 0 comments · Fixed by #550
Assignees
@jshort

Comments

@d-e-s-o
Copy link

d-e-s-o commented Feb 1, 2022 •
edited
Loading

When using the --tunnel option as suggested here, for example, but with slightly wrong input, et aborts hard.

# Instead of:
$ et -t 6010:22 <hostname>
# try
$ et -t 6010 <hostname>

The reason is this fragile raw indexing here (and below) without having checked that the index exists.
The program should probably be a bit more resilient to incorrect user input than a nondescript abort citing a std::vec violation of sorts.
@d-e-s-o d-e-s-o changed the title Out of bounds array access Out of bounds array access on caused by unexpected user input to --tunnel Feb 1, 2022
@jshort jshort self-assigned this Dec 2, 2022
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 2, 2022
@jshort
Fix tunnel parsing exception handling.
5648709 
Rather than using STFATAL and exiting, bubble up tunnel parsing
exception to main and display the responsible option arg and print help
menu so the user need not dig into /tmp/etclient-* to determine why et
aborted.

Fixes MisterTea#491
@jshort jshort mentioned this issue Dec 2, 2022
Merged
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 2, 2022
@jshort
Fix tunnel parsing exception handling.
9368b66 
Rather than using STFATAL and exiting, bubble up tunnel parsing
exception to main and display the responsible option arg and print help
menu so the user need not dig into /tmp/etclient-* to determine why et
aborted.

Fixes MisterTea#491
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 5, 2022
@jshort
Fix tunnel parsing exception handling.
b269b97 
Rather than using STFATAL and exiting, bubble up tunnel parsing
exception to main and display the responsible option arg and print help
menu so the user need not dig into /tmp/etclient-* to determine why et
aborted.

Fixes MisterTea#491
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 5, 2022
@jshort
Fix tunnel parsing exception handling.
5f1eadb 
Rather than using STFATAL and exiting, bubble up tunnel parsing
exception to main and display the responsible option arg and print help
menu so the user need not dig into /tmp/etclient-* to determine why et
aborted.

Fixes MisterTea#491
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 7, 2022
@jshort
Fix tunnel parsing exception handling.
2c8c529 
Rather than using STFATAL and exiting, bubble up tunnel parsing
exception to main and display the responsible option arg and print help
menu so the user need not dig into /tmp/etclient-* to determine why et
aborted.

Fixes MisterTea#491
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 7, 2022
@jshort
Fix tunnel parsing exception handling.
70db75a 
Rather than using STFATAL and exiting, bubble up tunnel parsing
exception to main and display the responsible option arg and print help
menu so the user need not dig into /tmp/etclient-* to determine why et
aborted.

Fixes MisterTea#491
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 7, 2022
@jshort
Fix tunnel parsing exception handling.
dbca326 
Rather than using STFATAL and exiting, bubble up tunnel parsing
exception to main and display the responsible option arg and print help
menu so the user need not dig into /tmp/etclient-* to determine why et
aborted.

Fixes MisterTea#491
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 13, 2022
@jshort
Fix tunnel parsing exception handling.
7d3afa8 
Rather than using STFATAL and exiting, bubble up tunnel parsing
exception to main and display the responsible option arg and print help
menu so the user need not dig into /tmp/etclient-* to determine why et
aborted.

Fixes MisterTea#491
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 13, 2022
@jshort
Fix tunnel parsing exception handling.
ef538a5 
Rather than using STFATAL and exiting, bubble up tunnel parsing
exception to main and display the responsible option arg and print help
menu so the user need not dig into /tmp/etclient-* to determine why et
aborted.

Fixes MisterTea#491
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 14, 2022
@jshort
Fix tunnel parsing exception handling.
4e16866 
Rather than using STFATAL and exiting, bubble up tunnel parsing
exception to main and display the responsible option arg and print help
menu so the user need not dig into /tmp/etclient-* to determine why et
aborted.

Fixes MisterTea#491
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 14, 2022
@jshort
Fix tunnel parsing exception handling.
aff4ad7 
Rather than using STFATAL and exiting, bubble up tunnel parsing
exception to main and display the responsible option arg and print help
menu so the user need not dig into /tmp/etclient-* to determine why et
aborted.

Fixes MisterTea#491
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 14, 2022
@jshort
Fix tunnel parsing exception handling.
dc88b29 
Rather than using STFATAL and exiting, bubble up tunnel parsing
exception to main and display the responsible option arg and print help
menu so the user need not dig into /tmp/etclient-* to determine why et
aborted.

Fixes MisterTea#491
jshort added a commit that referenced this issue Dec 14, 2022
@jshort
Fix tunnel parsing exception handling. (#550)
10dd371 
Rather than using STFATAL and exiting, bubble up tunnel parsing
exception to main and display the responsible option arg and print help
menu so the user need not dig into /tmp/etclient-* to determine why et
aborted.

Fixes #491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshort jshort

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tunnel parsing exception handling. jshort/EternalTerminal
2 participants
@jshort @d-e-s-o