Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force reverse tunnel socket to be binded to localhost #600

Merged
merged 2 commits into from Sep 4, 2023

Conversation

lostystyg
Copy link
Contributor

@lostystyg lostystyg commented Sep 1, 2023

Fixes #587

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.43% ⚠️

Comparison is base (4d07910) 72.87% compared to head (7f4335f) 72.45%.
Report is 2 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
- Coverage   72.87%   72.45%   -0.43%     
==========================================
  Files          50       50              
  Lines        3042     3042              
==========================================
- Hits         2217     2204      -13     
- Misses        825      838      +13     
Files Changed Coverage Δ
src/terminal/forwarding/PortForwardHandler.cpp 3.79% <ø> (+0.04%) ⬆️
src/base/TunnelUtils.cpp 93.47% <100.00%> (+0.29%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MisterTea
Copy link
Owner

@lostystyg the CI is failing. Can you try rebasing on latest master?

@MisterTea
Copy link
Owner

nevermind, it's a bad test. Thanks for the PR

@MisterTea MisterTea merged commit 2f8dfdd into MisterTea:master Sep 4, 2023
25 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reverse tunnel listen interface
3 participants