Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespell support (config, CI action to detect new typos) + fix some typos #605

Merged
merged 5 commits into from Nov 10, 2023

Conversation

yarikoptic
Copy link
Contributor

No description provided.

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2f8dfdd) 73.47% compared to head (721c23d) 73.02%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
- Coverage   73.47%   73.02%   -0.45%     
==========================================
  Files          50       50              
  Lines        3042     3051       +9     
==========================================
- Hits         2235     2228       -7     
- Misses        807      823      +16     
Files Coverage Δ
src/base/BackedReader.cpp 84.41% <ø> (ø)
src/base/SocketHandler.cpp 63.63% <ø> (ø)
src/terminal/ServerFifoPath.cpp 57.89% <0.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MisterTea
Copy link
Owner

Hey, I'm not sure why we are failing the clang-format test now, but can you fix those before merging?

@yarikoptic
Copy link
Contributor Author

I will submit later pr without changes to check if that check is green on general - https://github.com/MisterTea/EternalTerminal/actions/workflows/clang-format-check.yml shows that last time it was ran was 2 months ago, so may be just some new version of tooling causes it now to fail, not that changes in this pr

@KapJI
Copy link
Contributor

KapJI commented Nov 9, 2023

Clang-format is right here, extra letter made { in that block unaligned. I guess you need to add an extra space for those lines.

…despell

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "clang-format -i src/terminal/TelemetryService.cpp",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@yarikoptic
Copy link
Contributor Author

thanks, pushed results of clang-format -i src/terminal/TelemetryService.cpp -- let's see how it feels now!

@MisterTea
Copy link
Owner

Thanks!

@MisterTea MisterTea merged commit 4b2ca6d into MisterTea:master Nov 10, 2023
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants